Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GroupReadQueue to support committing without writing the response #70

Open
jorgebay opened this issue Oct 19, 2022 · 0 comments
Open

Refactor GroupReadQueue to support committing without writing the response #70

jorgebay opened this issue Oct 19, 2022 · 0 comments
Labels
code quality How an existing feature is implemented / refactor required for simplification enhancement New feature or request

Comments

@jorgebay
Copy link
Contributor

GroupReadQueue streams the consumer response and handles manual commits.

We should also commit on the "goodbye" consumer message but without affecting the response.

We should refactor GroupReadQueue to only write the response on some occasions.
@jorgebay jorgebay added enhancement New feature or request code quality How an existing feature is implemented / refactor required for simplification labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality How an existing feature is implemented / refactor required for simplification enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgebay