Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doFirstTimeUse completes prematurely, before all underlying operations finish #494

Closed
3 of 10 tasks
korzonkiee opened this issue Oct 29, 2024 · 6 comments · May be fixed by #515
Closed
3 of 10 tasks

doFirstTimeUse completes prematurely, before all underlying operations finish #494

korzonkiee opened this issue Oct 29, 2024 · 6 comments · May be fixed by #515
Labels
bug Something isn't working

Comments

@korzonkiee
Copy link
Contributor

Platform on which you observed the bug:

  • Android
  • iOS
  • Other
  • Platform is not relevant for this bug

Device on which you observed the bug:

  • Polar OH1
  • Polar Verity Sense
  • Polar H10
  • Polar H9
  • Other
  • Device is not relevant for this bug

Describe the bug
doFirstTimeUse completes as soon as FTU config is sent to the device (here), but it should wait until other operations complete.

How to Reproduce
Call doFirstTimeUse method.

Expected behavior
doFirstTimeUse method should complete when all the underlying operations are finished.

Screenshots and logs
See video below that shows the execution order during debugging.

CleanShot.2024-10-28.at.16.05.36.mp4
@korzonkiee korzonkiee added the bug Something isn't working label Oct 29, 2024
@samulimaa
Copy link
Contributor

Hi, thanks for reporting this, we have created internal ticket to fix this on upcoming releases.

@samulimaa
Copy link
Contributor

Fixed in SDK 5.9.0.

@korzonkiee
Copy link
Contributor Author

Hey @samulimaa, unfortunately the issue is still not resolved. These changes call emitter.complete as soon as stream is subscribed too, whereas it should be called when underlying operations finish, i.e. when client.write & setLocalTime completes.

@korzonkiee korzonkiee mentioned this issue Dec 5, 2024
Open
@korzonkiee
Copy link
Contributor Author

@samulimaa whenever you have time, please check out the #515 PR that I open with fix for this issue. Would appreciate a review 🙏

@samulimaa
Copy link
Contributor

Hi, your PR looks good. However we can't directly merge these public SDK PRs because of our internal review and QA processes, but these fix proposals are greatly appreciated!

@palmqvisti
Copy link
Contributor

FLOW-60982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@korzonkiee @samulimaa @palmqvisti