Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename waitDeviceSessionToOpen to waitDeviceSessionWithPftpToOpen and update it so that it waits for PFTP client to be ready #496 #516

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Rename waitDeviceSessionToOpen to waitDeviceSessionWithPftpToOpen and update it so that it waits for PFTP client to be ready #496 #516

wants to merge 3 commits into from

Conversation

korzonkiee
Copy link
Contributor

@korzonkiee korzonkiee commented Dec 6, 2024 •
edited
Loading

Fixes #496

@korzonkiee
Copy link
Contributor Author

Testing in progress...

@korzonkiee korzonkiee marked this pull request as draft December 6, 2024 09:03
@jimmyzumthurm jimmyzumthurm self-requested a review December 6, 2024 09:13
@jimmyzumthurm
Copy link
Member

PFTP should be used instead of FTP. PFTP stands for Polar File Transfer Protocol, which is using Polar own BLE service.

@korzonkiee korzonkiee changed the title Rename waitDeviceSessionToOpen to waitDeviceSessionWithFtpToOpen and update it so that it waits for FTP client to be ready #496 Rename waitDeviceSessionToOpen to waitDeviceSessionWithPftpToOpen and update it so that it waits for FTP client to be ready #496 Dec 6, 2024
@korzonkiee korzonkiee changed the title Rename waitDeviceSessionToOpen to waitDeviceSessionWithPftpToOpen and update it so that it waits for FTP client to be ready #496 Rename waitDeviceSessionToOpen to waitDeviceSessionWithPftpToOpen and update it so that it waits for PFTP client to be ready #496 Dec 6, 2024
@korzonkiee
Copy link
Contributor Author

korzonkiee commented Dec 6, 2024 •
edited
Loading

@jimmyzumthurm thanks for the feedback! Addressed in 10fd25d & d238bcd.

@korzonkiee korzonkiee mentioned this pull request Dec 9, 2024
Open
10 tasks
@korzonkiee korzonkiee marked this pull request as ready for review December 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyzumthurm jimmyzumthurm Awaiting requested review from jimmyzumthurm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updateFirmware fails on iOS SDK 5.8.0 (VeritySense) with notificationNotEnabled error
2 participants
@korzonkiee @jimmyzumthurm