From d4d6941dd3f14da48d60aa315c806fe05685c0b6 Mon Sep 17 00:00:00 2001 From: Bryan White Date: Fri, 14 Apr 2023 13:22:38 +0200 Subject: [PATCH 1/2] docs: add ADR0002 --- ADRs/0002-separate-consensus-and-p2p-ids.md | 53 +++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 ADRs/0002-separate-consensus-and-p2p-ids.md diff --git a/ADRs/0002-separate-consensus-and-p2p-ids.md b/ADRs/0002-separate-consensus-and-p2p-ids.md new file mode 100644 index 0000000..461f771 --- /dev/null +++ b/ADRs/0002-separate-consensus-and-p2p-ids.md @@ -0,0 +1,53 @@ +# ADR-0002: Separate consensus and P2P IDs + +* Status: draft +* Deciders: Pocket Network team +* Date: 2023-04-17 + +Technical Story: [Review Hotstuff Node IDs](https://github.com/pokt-network/pocket/issue/434) + +## Context and Problem Statement + +In the context of simplifying and consolidating node identity, facing the concern of multiple ID definitions, we decided to clarify the purpose of consensus NodeId and not consolidate it with P2P identity, to achieve a clearer separation of concerns, accepting potential confusion between different IDs, because this will prevent unintended interference between consensus and P2P layers. + +## Decision Drivers + +* Clear separation of concerns between consensus and P2P layers +* Preventing unintended interference between different node identity types + +## Considered Options + +* Consolidate consensus NodeId with P2P identity +* Keep consensus NodeId and P2P identity separate + +## Decision Outcome + +Chosen option: "Keep consensus NodeId and P2P identity separate", because it prevents unintended interference between consensus and P2P layers while maintaining a clear separation of concerns. + +### Positive Consequences + +* Clear separation of concerns between consensus and P2P layers +* Avoids unintended interference between different node identity types + +### Negative Consequences + +* Potential confusion between different node identity types +* Maintaining multiple ID definitions + +## Pros and Cons of the Options + +### Consolidate consensus NodeId with P2P identity + +* Good, because it simplifies node identity management +* Bad, because it may lead to confusion and unintended interference between consensus and P2P layers + +### Keep consensus NodeId and P2P identity separate + +* Good, because it maintains a clear separation of concerns between consensus and P2P layers +* Good, because it avoids unintended interference between different node identity types +* Bad, because it may lead to potential confusion between different node identity types +* Bad, because it requires maintaining multiple ID definitions + +### Links + +* [pokt-network/pocket#348](https://github.com/pokt-network/pocket/issue/348) \ No newline at end of file From 5eb4a9c35fe43e43bd59a5bdbd6189cbe4e52a65 Mon Sep 17 00:00:00 2001 From: Bryan White Date: Fri, 21 Apr 2023 09:14:43 +0200 Subject: [PATCH 2/2] ADR0002: status "in review" --- ADRs/0002-separate-consensus-and-p2p-ids.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ADRs/0002-separate-consensus-and-p2p-ids.md b/ADRs/0002-separate-consensus-and-p2p-ids.md index 461f771..c9b032b 100644 --- a/ADRs/0002-separate-consensus-and-p2p-ids.md +++ b/ADRs/0002-separate-consensus-and-p2p-ids.md @@ -1,6 +1,6 @@ # ADR-0002: Separate consensus and P2P IDs -* Status: draft +* Status: in review * Deciders: Pocket Network team * Date: 2023-04-17