Skip to content

Commit d061f8c

Browse files
docs: add ADR0002
1 parent 6d3b12d commit d061f8c

1 file changed

Lines changed: 54 additions & 0 deletions

File tree

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# ADR-0002: Separate consensus and P2P IDs
2+
3+
* Status: draft
4+
* Deciders: Pocket Network team
5+
* Date: 2023-04-17
6+
7+
Technical Story: Simplifying and consolidating node identity.
8+
9+
## Context and Problem Statement
10+
11+
In the context of simplifying and consolidating node identity, facing the concern of multiple ID definitions, we decided to clarify the purpose of consensus NodeId and not consolidate it with P2P identity, to achieve a clearer separation of concerns, accepting potential confusion between different IDs, because this will prevent unintended interference between consensus and P2P layers.
12+
13+
## Decision Drivers
14+
15+
* Clear separation of concerns between consensus and P2P layers
16+
* Preventing unintended interference between different node identity types
17+
18+
## Considered Options
19+
20+
* Consolidate consensus NodeId with P2P identity
21+
* Keep consensus NodeId and P2P identity separate
22+
23+
## Decision Outcome
24+
25+
Chosen option: "Keep consensus NodeId and P2P identity separate", because it prevents unintended interference between consensus and P2P layers while maintaining a clear separation of concerns.
26+
27+
### Positive Consequences
28+
29+
* Clear separation of concerns between consensus and P2P layers
30+
* Avoids unintended interference between different node identity types
31+
32+
### Negative Consequences
33+
34+
* Potential confusion between different node identity types
35+
* Maintaining multiple ID definitions
36+
37+
## Pros and Cons of the Options
38+
39+
### Consolidate consensus NodeId with P2P identity
40+
41+
* Good, because it simplifies node identity management
42+
* Bad, because it may lead to confusion and unintended interference between consensus and P2P layers
43+
44+
### Keep consensus NodeId and P2P identity separate
45+
46+
* Good, because it maintains a clear separation of concerns between consensus and P2P layers
47+
* Good, because it avoids unintended interference between different node identity types
48+
* Bad, because it may lead to potential confusion between different node identity types
49+
* Bad, because it requires maintaining multiple ID definitions
50+
51+
### Links
52+
53+
* [pokt-network/pocket#348](https://github.com/pokt-network/pocket/issue/348)
54+
* [pokt-network/pocket#434](https://github.com/pokt-network/pocket/issue/434)

0 commit comments

Comments
 (0)