Fix - SQL syntax errors in cronComputeLateOrders method (#509)

* Fix - SQL syntax errors in cronComputeLateOrders method

* Update CHANGELOG

* Fix Rector

Author: RomainLvr

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [UNRELEASED]
+
+### Fixed
+
+- Fix SQL syntax errors in cronComputeLateOrders cron task
+
 ## [2.12.2] - 2025-11-13
 
 ### Fixed

inc/order.class.php

@@ -2399,44 +2399,46 @@ public static function cronComputeLateOrders($task)
             $config  = PluginOrderConfig::getConfig();
 
             $query = [
-                'SELECT' => `id`,
-                'FROM' => `glpi_entities`,
-                'ORDER' => `id ASC`,
+                'SELECT' => 'id',
+                'FROM' => 'glpi_entities',
+                'ORDER' => 'id ASC',
             ];
 
             $entities[] = 0;
             foreach ($DB->request($query) as $entity) {
                 $entities[] = $entity['id'];
             }
 
+
             foreach ($entities as $entity) {
                 $query_alert = [
                     'SELECT' => [
-                        `$table.id AS id`,
-                        `$table.name AS name`,
-                        `$table.num_order AS num_order`,
-                        `$table.order_date AS order_date`,
-                        `$table.duedate AS duedate`,
-                        `$table.deliverydate AS deliverydate`,
-                        `$table.comment AS comment`,
-                        `$table.plugin_order_orderstates_id AS plugin_order_orderstates_id`,
-                        `glpi_alerts.id AS alertID`,
-                        `glpi_alerts.date`,
+                        $table . '.id AS id',
+                        $table . '.name AS name',
+                        $table . '.num_order AS num_order',
+                        $table . '.order_date AS order_date',
+                        $table . '.duedate AS duedate',
+                        $table . '.deliverydate AS deliverydate',
+                        $table . '.comment AS comment',
+                        $table . '.plugin_order_orderstates_id AS plugin_order_orderstates_id',
+                        "glpi_alerts.id AS alertID",
+                        "glpi_alerts.date",
                     ],
                     'FROM' => $table,
                     'LEFT JOIN' => [
-                        `glpi_alerts` => [
+                        'glpi_alerts' => [
                             'ON' => [
-                                sprintf('`%s`.`id` = `glpi_alerts`.`items_id`', $table),
-                                "`glpi_alerts`.`itemtype` = '" . self::class . "'",
+                                'glpi_alerts' => 'items_id',
+                                $table => 'id',
+                                ['AND' => ['glpi_alerts.itemtype' => self::class]],
                             ],
                         ],
                     ],
                     'WHERE' => [
                         $table . '.entities_id' => $entity,
-                        "glpi_alerts.date" => "IS NULL",
-                        $table . '.is_late' => "1",
-                        $table . '.plugin_order_orderstates_id' => "!=" . $config->getDeliveredState(),
+                        'glpi_alerts.date' => null,
+                        $table . '.is_late' => 1,
+                        'NOT' => [$table . '.plugin_order_orderstates_id' => $config->getDeliveredState()],
                     ],
                 ];
                 $orders = [];