Skip to content

Commit 08a0924

Browse files
adressing warning, cleanup readme
1 parent 96738c9 commit 08a0924

File tree

2 files changed

+34
-14
lines changed

2 files changed

+34
-14
lines changed

README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ class App extends React.Component {
3636
}
3737

3838
render() {
39-
return <PivotTableUI data={data} onChange={s => this.setState(s)} />;
39+
return <PivotTableUI data={data} onChange={s => this.setState(s)}
40+
{...this.state} />;
4041
}
4142
}
4243

@@ -78,9 +79,9 @@ class App extends React.Component {
7879

7980
render() {
8081
return <PivotTableUI
81-
data={data} onChange={s => this.setState(s)}
82-
renderers={Object.assign({}, TableRenderers, PlotlyRenderers)}
83-
/>;
82+
data={data} onChange={s => this.setState(s)}
83+
renderers={Object.assign({}, TableRenderers, PlotlyRenderers)}
84+
{...this.state} />;
8485
}
8586
}
8687

@@ -117,9 +118,9 @@ class App extends React.Component {
117118

118119
render() {
119120
return <PivotTableUI
120-
data={data} onChange={s => this.setState(s)}
121-
renderers={Object.assign({}, TableRenderers, PlotlyRenderers)}
122-
/>;
121+
data={data} onChange={s => this.setState(s)}
122+
renderers={Object.assign({}, TableRenderers, PlotlyRenderers)}
123+
{...this.state} />;
123124
}
124125
}
125126

src/PivotTableUI.jsx

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,11 @@ class DraggableAttribute extends React.Component {
7575
placeholder="Filter values"
7676
className="pvtSearch"
7777
value={this.state.filterText}
78-
onChange={e => this.setState({filterText: e.target.value})}
78+
onChange={e =>
79+
this.setState({
80+
filterText: e.target.value,
81+
})
82+
}
7983
/>
8084
<br />
8185
<a
@@ -321,7 +325,9 @@ class PivotTableUI extends React.PureComponent {
321325
}
322326

323327
removeValuesFromFilter(attribute, values) {
324-
this.sendPropUpdate({valueFilter: {[attribute]: {$unset: values}}});
328+
this.sendPropUpdate({
329+
valueFilter: {[attribute]: {$unset: values}},
330+
});
325331
}
326332

327333
moveFilterBoxToTop(attribute) {
@@ -396,8 +402,16 @@ class PivotTableUI extends React.PureComponent {
396402
);
397403

398404
const sortIcons = {
399-
key_a_to_z: {rowSymbol: '↕', colSymbol: '↔', next: 'value_a_to_z'},
400-
value_a_to_z: {rowSymbol: '↓', colSymbol: '→', next: 'value_z_to_a'},
405+
key_a_to_z: {
406+
rowSymbol: '↕',
407+
colSymbol: '↔',
408+
next: 'value_a_to_z',
409+
},
410+
value_a_to_z: {
411+
rowSymbol: '↓',
412+
colSymbol: '→',
413+
next: 'value_z_to_a',
414+
},
401415
value_z_to_a: {rowSymbol: '↑', colSymbol: '←', next: 'key_a_to_z'},
402416
};
403417

@@ -436,6 +450,7 @@ class PivotTableUI extends React.PureComponent {
436450
{numValsAllowed > 0 && <br />}
437451
{new Array(numValsAllowed).fill().map((n, i) => [
438452
<Dropdown
453+
key={i}
439454
current={this.props.vals[i]}
440455
values={Object.keys(this.attrValues).filter(
441456
e =>
@@ -450,10 +465,12 @@ class PivotTableUI extends React.PureComponent {
450465
})
451466
}
452467
setValue={value =>
453-
this.sendPropUpdate({vals: {$splice: [[i, 1, value]]}})
468+
this.sendPropUpdate({
469+
vals: {$splice: [[i, 1, value]]},
470+
})
454471
}
455472
/>,
456-
i + 1 !== numValsAllowed ? <br /> : null,
473+
i + 1 !== numValsAllowed ? <br key={`br${i}`} /> : null,
457474
])}
458475
</td>
459476
);
@@ -504,7 +521,9 @@ class PivotTableUI extends React.PureComponent {
504521
const outputCell = (
505522
<td className="pvtOutput">
506523
<PivotTable
507-
{...update(this.props, {data: {$set: this.materializedInput}})}
524+
{...update(this.props, {
525+
data: {$set: this.materializedInput},
526+
})}
508527
/>
509528
</td>
510529
);

0 commit comments

Comments
 (0)