Merge pull request #7418 from plotly/fix-font-redirects-ci

Update font URLs and add additional error handling

Author: emilykl

.circleci/config.yml

@@ -44,7 +44,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:
@@ -83,7 +83,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:
@@ -105,7 +105,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:
@@ -127,7 +127,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:
@@ -168,7 +168,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:
@@ -189,7 +189,7 @@ jobs:
           install-firefox: false
           install-geckodriver: false
           install-chrome: true
-          chrome-version: "127.0.6533.119"
+          chrome-version: "132.0.6834.110"
       - attach_workspace:
           at: ~/
       - run:

.circleci/download_google_fonts.py

@@ -1,97 +1,82 @@
+import os
+
 import requests
 
-dirOut = '.circleci/fonts/truetype/googleFonts/'
+dir_out = ".circleci/fonts/truetype/googleFonts/"
+
 
-def download(repo, family, types):
-    for t in types :
-        name = family + t + '.ttf'
-        url = repo + name + '?raw=true'
-        print(url)
-        req = requests.get(url, allow_redirects=True)
+def download(repo, family, types, overwrite=True):
+    for t in types:
+        name = family + t + ".ttf"
+        url = repo + name + "?raw=true"
+        out_file = dir_out + name
+        print("Getting: ", url)
+        if os.path.exists(out_file) and not overwrite:
+            print("    => Already exists: ", out_file)
+            continue
+        req = requests.get(url, allow_redirects=False)
         if req.status_code != 200:
+            # If we get a redirect, print an error so that we know to update the URL
+            if req.status_code == 302 or req.status_code == 301:
+                new_url = req.headers.get("Location")
+                print(f"    => Redirected -- please update URL to: {new_url}")
             raise RuntimeError(f"""
 Download failed.
 Status code: {req.status_code}
 Message: {req.reason}
-"""
-            )
-        open(dirOut + name, 'wb').write(req.content)
+""")
+        open(out_file, "wb").write(req.content)
+
 
 download(
-    'https://github.com/googlefonts/noto-fonts/blob/main/hinted/ttf/NotoSansMono/',
-    'NotoSansMono',
-    [
-        '-Regular',
-        '-Bold'
-    ]
+    "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSansMono/hinted/ttf/",
+    "NotoSansMono",
+    ["-Regular", "-Bold"],
 )
 
 download(
-    'https://github.com/googlefonts/noto-fonts/blob/main/hinted/ttf/NotoSans/',
-    'NotoSans',
-    [
-        '-Regular',
-        '-Italic',
-        '-Bold'
-    ]
+    "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSans/hinted/ttf/",
+    "NotoSans",
+    ["-Regular", "-Italic", "-Bold"],
 )
 
 download(
-    'https://github.com/googlefonts/noto-fonts/blob/main/hinted/ttf/NotoSerif/',
-    'NotoSerif',
+    "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSerif/hinted/ttf/",
+    "NotoSerif",
     [
-        '-Regular',
-        '-Italic',
-        '-Bold',
-        '-BoldItalic',
-    ]
+        "-Regular",
+        "-Italic",
+        "-Bold",
+        "-BoldItalic",
+    ],
 )
 
 download(
-    'https://github.com/google/fonts/blob/main/ofl/oldstandardtt/',
-    'OldStandard',
-    [
-        '-Regular',
-        '-Italic',
-        '-Bold'
-    ]
+    "https://raw.githubusercontent.com/google/fonts/refs/heads/main/ofl/oldstandardtt/",
+    "OldStandard",
+    ["-Regular", "-Italic", "-Bold"],
 )
 
 download(
-    'https://github.com/google/fonts/blob/main/ofl/ptsansnarrow/',
-    'PT_Sans-Narrow-Web',
-    [
-        '-Regular',
-        '-Bold'
-    ]
+    "https://raw.githubusercontent.com/google/fonts/refs/heads/main/ofl/ptsansnarrow/",
+    "PT_Sans-Narrow-Web",
+    ["-Regular", "-Bold"],
 )
 
 download(
-    'https://github.com/impallari/Raleway/blob/master/fonts/v3.000%20Fontlab/TTF/',
-    'Raleway',
-    [
-        '-Regular',
-        '-Regular-Italic',
-        '-Bold',
-        '-Bold-Italic'
-    ]
+    "https://raw.githubusercontent.com/impallari/Raleway/refs/heads/master/fonts/v3.000%20Fontlab/TTF/",
+    "Raleway",
+    ["-Regular", "-Regular-Italic", "-Bold", "-Bold-Italic"],
 )
 
 download(
-    'https://github.com/googlefonts/roboto/blob/main/src/hinted/',
-    'Roboto',
-    [
-        '-Regular',
-        '-Italic',
-        '-Bold',
-        '-BoldItalic'
-    ]
+    "https://raw.githubusercontent.com/googlefonts/roboto-2/refs/heads/main/src/hinted/",
+    "Roboto",
+    ["-Regular", "-Italic", "-Bold", "-BoldItalic"],
 )
 
 download(
-    'https://github.com/expo/google-fonts/blob/main/font-packages/gravitas-one/400Regular/',
-    'GravitasOne',
-    [
-        '_400Regular'
-    ]
+    "https://raw.githubusercontent.com/expo/google-fonts/refs/heads/main/font-packages/gravitas-one/400Regular/",
+    "GravitasOne",
+    ["_400Regular"],
 )

.circleci/env_image.sh

@@ -1,9 +1,10 @@
 #!/bin/sh
+set -e
 # install required fonts
-sudo apt-get install fonts-liberation2 fonts-open-sans fonts-noto-cjk fonts-noto-color-emoji && \
-sudo python3 .circleci/download_google_fonts.py && \
-sudo cp -r .circleci/fonts/ /usr/share/ && \
-sudo fc-cache -f && \
+sudo apt-get install fonts-liberation2 fonts-open-sans fonts-noto-cjk fonts-noto-color-emoji
+sudo python3 .circleci/download_google_fonts.py
+sudo cp -r .circleci/fonts/ /usr/share/
+sudo fc-cache -f
 # install kaleido & plotly
 sudo python3 -m pip install kaleido==0.2.1 plotly==5.5.0 --progress-bar off
 # install numpy i.e. to convert arrays to typed arrays