Add tickmode 'full domain'

Author: ayjayt

src/plot_api/plot_api.js

@@ -2945,7 +2945,11 @@ function getDiffFlags(oldContainer, newContainer, outerparts, opts) {
         // so newContainer won't have them.
         if((key === 'tick0' || key === 'dtick') && outerparts[0] !== 'geo') {
             var tickMode = newContainer.tickmode;
-            if(tickMode === 'auto' || tickMode === 'array' || tickMode === 'domain array' || !tickMode) continue;
+            if(tickMode === 'auto'
+              || tickMode === 'array'
+              || tickMode === 'domain array'
+              || tickMode === 'full domain'
+              || !tickMode) continue;
         }
         // FIXME: Similarly for axis ranges for 3D
         // contourcarpet doesn't HAVE zmin/zmax, they're just auto-added. It needs them.

src/plots/cartesian/axes.js

@@ -682,10 +682,13 @@ axes.prepTicks = function(ax, opts) {
             if(ax._name === 'radialaxis') nt *= 2;
         }
 
-        if(!(ax.minor && (ax.minor.tickmode !== 'array' && ax.minor.tickmode !== 'domain array'))) {
+        if(!(ax.minor &&
+          (ax.minor.tickmode !== 'array' 
+            && ax.minor.tickmode !== 'domain array' 
+            && ax.minor.tickmode !== 'full domain'))) {
             // add a couple of extra digits for filling in ticks when we
             // have explicit tickvals without tick text
-            if(ax.tickmode === 'array' || ax.tickmode === 'domain array') nt *= 100;
+            if(ax.tickmode === 'array' || ax.tickmode === 'domain array' || ax.tickmode === 'full domain') nt *= 100;
         }
 
         ax._roughDTick = Math.abs(rng[1] - rng[0]) / nt;
@@ -948,14 +951,37 @@ axes.calcTicks = function calcTicks(ax, opts) {
         } else {
             axes.prepTicks(mockAx, opts);
         }
-
+        
+        if(mockAx.tickmode === 'full domain'){
+            nt = mockAx.nticks;  // does mockAx have nitkcs?
+            var tickVals = []; 
+            if (nt == 0) {
+              // pass
+            } else if (nt == 1) {
+                tickVals = [0];
+            } else if (nt == 2) {
+                tickVals = [0, 1];
+            } else {
+                var increment = 1/(nt-2);
+                tickVals.push(0);
+                for (let i = 0; i < nt-2; i++) {
+                    tickVals.push((i+1)*incremente);
+                }
+                tickVals.push(1);
+            }
+            if (major) {
+                Lib.nestedProperty(ax, 'tickvals').set(tickVals);
+            } else {
+                Lib.nestedProperty(ax.minor, 'tickvals').set(tickVals);
+            }
+        }
         // tickmode 'domain array' is just 'array' but with a pre-calc step
         // original comment:
         // now that we've figured out the auto values for formatting
         // in case we're missing some ticktext, we can break out for array ticks
-        if(mockAx.tickmode === 'array' || mockAx.tickmode === 'domain array') {
+        if(mockAx.tickmode === 'array' || mockAx.tickmode === 'domain array' || mockAx.tickmode === 'full domain' ) {
             // Mapping proportions to array:
-            if(mockAx.tickmode === 'domain array') {
+            if(mockAx.tickmode === 'domain array' || mockAx.tickmode === 'full domain') {
                 var width = (maxRange - minRange);
                 if(axrev) width *= -1;
                 var offset = !axrev ? minRange : maxRange;
@@ -1251,10 +1277,12 @@ axes.calcTicks = function calcTicks(ax, opts) {
     // Reset tickvals back to domain array
     if(tickFractionalVals._isSet) {
         delete tickFractionalVals._isSet;
+        if (ax.tickmode === 'full domain') tickFractionalVals = [];
         Lib.nestedProperty(ax, 'tickvals').set(tickFractionalVals);
     }
     if(minorTickFractionalVals._isSet) {
         delete tickFractionalVals._isSet;
+        if (ax.minor.tickmode === 'full domain') tickFractionalVals = [];
         Lib.nestedProperty(ax.minor, 'tickvals').set(minorTickFractionalVals);
     }
 
@@ -1662,7 +1690,7 @@ axes.tickFirst = function(ax, opts) {
 // more precision for hovertext
 axes.tickText = function(ax, x, hover, noSuffixPrefix) {
     var out = tickTextObj(ax, x);
-    var arrayMode = (ax.tickmode === 'array' || ax.tickmode === 'domain array');
+    var arrayMode = (ax.tickmode === 'array' || ax.tickmode === 'domain array' || ax.tickmode === 'full domain');
     var extraPrecision = hover || arrayMode;
     var axType = ax.type;
     // TODO multicategory, if we allow ticktext / tickvals
@@ -3378,7 +3406,7 @@ axes.drawGrid = function(gd, ax, opts) {
 
     var counterAx = opts.counterAxis;
     if(counterAx && axes.shouldShowZeroLine(gd, ax, counterAx)) {
-        var isArrayMode = (ax.tickmode === 'array' || ax.tickmode === 'domain array');
+        var isArrayMode = (ax.tickmode === 'array' || ax.tickmode === 'domain array' || ax.tickmode === 'full domain');
         for(var i = 0; i < majorVals.length; i++) {
             var xi = majorVals[i].x;
             if(isArrayMode ? !xi : (Math.abs(xi) < ax.dtick / 100)) {

src/plots/cartesian/layout_attributes.js

@@ -14,7 +14,7 @@ var DAY_OF_WEEK = constants.WEEKDAY_PATTERN;
 
 var minorTickmode = {
     valType: 'enumerated',
-    values: ['auto', 'linear', 'array', 'domain array'],
+    values: ['auto', 'linear', 'array', 'domain array', 'full domain'],
     editType: 'ticks',
     impliedEdits: {tick0: undefined, dtick: undefined},
     description: [
@@ -26,6 +26,10 @@ var minorTickmode = {
         'If *array*, the placement of the ticks is set via `tickvals`,',
         'which are actual values, and the tick text is `ticktext`.',
         '(*array* is the default value if `tickvals` is provided).',
+        'If *full domain*, the number of ticks is set bia `nticks` but ticks',
+        'are placed first at both axis ends and then at equal proportions',
+        'between the axis. So `nticks=5` would put ticks at both ends and',
+        'every quarter.',
         'If *domain array*, the placement is similiar to *array* except that',
         '`tickvals` are fractions between 0 and 1 representing distance on',
         'the corresponding axis.'

test/jasmine/tests/pikul_test.js

@@ -5,7 +5,7 @@ var createGraphDiv = require('../assets/create_graph_div');
 var destroyGraphDiv = require('../assets/destroy_graph_div');
 
 // Boilerplate taken from axes_test.js
-describe('When generating axes w/ `tickmode`:"proportional",', function() {
+describe('When generating axes w/ `tickmode`:"domain array",', function() {
   var gd;
 
   beforeEach(function() {
@@ -21,7 +21,7 @@ describe('When generating axes w/ `tickmode`:"proportional",', function() {
   function generateTickConfig(tickLen){
     // Intentionally configure to produce a single `(x|y)tick` class per tick
     // labels and tick marks each produce one, so one or the other
-    standardConfig = {tickmode: 'proportional', ticklen: tickLen, showticklabels: false};
+    standardConfig = {tickmode: 'domain array', ticklen: tickLen, showticklabels: false};
 
     // Tick values will be random:
     var n = Math.floor(Math.random() * 100);