Merge pull request #7236 from plotly/drop-autotick

Drop deprecated `autotick` attributes from cartesian and gl3d axes

Author: archmoj

draftlogs/7236_remove.md

@@ -0,0 +1 @@
+ - Drop deprecated autotick attributes from cartesian and gl3d axes [[#7236](https://github.com/plotly/plotly.js/pull/7236)]

src/plot_api/helpers.js

@@ -81,15 +81,6 @@ exports.cleanLayout = function(layout) {
 
             // prune empty domain arrays made before the new nestedProperty
             if(emptyContainer(ax, 'domain')) delete ax.domain;
-
-            // autotick -> tickmode
-            if(ax.autotick !== undefined) {
-                if(ax.tickmode === undefined) {
-                    ax.tickmode = ax.autotick ? 'auto' : 'linear';
-                }
-                delete ax.autotick;
-            }
-
         }
     }
 

src/plots/cartesian/layout_attributes.js

@@ -1230,16 +1230,4 @@ module.exports = {
         ].join(' ')
     },
     editType: 'calc',
-
-    _deprecated: {
-        autotick: {
-            valType: 'boolean',
-            editType: 'ticks',
-            description: [
-                'Obsolete.',
-                'Set `tickmode` to *auto* for old `autotick` *true* behavior.',
-                'Set `tickmode` to *linear* for `autotick` *false*.'
-            ].join(' ')
-        },
-    }
 };

src/plots/cartesian/set_convert.js

@@ -58,7 +58,7 @@ function isValidCategory(v) {
  * Creates/updates these conversion functions, and a few more utilities
  * like cleanRange, and makeCalcdata
  *
- * also clears the autotick constraints ._minDtick, ._forceTick0
+ * also clears ._minDtick, ._forceTick0
  */
 module.exports = function setConvert(ax, fullLayout) {
     fullLayout = fullLayout || {};

src/plots/gl3d/layout/tick_marks.js

@@ -52,9 +52,9 @@ function computeTickMarks(scene) {
                 axes.range[1] += 1;
             }
             // this is necessary to short-circuit the 'y' handling
-            // in autotick part of calcTicks... Treating all axes as 'y' in this case
-            // running the autoticks here, then setting
-            // autoticks to false to get around the 2D handling in calcTicks.
+            // in tickmode part of calcTicks... Treating all axes as 'y' in this case
+            // running the tickmode here, then setting
+            // automode to linear to get around the 2D handling in calcTicks.
             var tickModeCached = axes.tickmode;
             if(axes.tickmode === 'auto') {
                 axes.tickmode = 'linear';

tasks/test_mock.mjs

@@ -144,9 +144,7 @@ function notBlackListed(name) {
         '32',
         'annotations',
         'annotations-autorange',
-        'axes_booleans',
         'axes_labels',
-        'axes-ticks',
         'candlestick_double-y-axis',
         'candlestick_rangeslider_thai',
         'category-autorange',
@@ -163,7 +161,6 @@ function notBlackListed(name) {
         'gl2d_14',
         'gl2d_17',
         'gl2d_annotations',
-        'gl2d_axes_booleans',
         'gl2d_axes_labels',
         'gl2d_fill_trace_tozero_order',
         'gl2d_fonts',

test/image/mocks/11.json

@@ -96,7 +96,7 @@
    "showgrid": true,
    "zeroline": false,
    "showline": false,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 0,
    "ticks": "",
    "showticklabels": true,
@@ -140,7 +140,7 @@
    "showgrid": true,
    "zeroline": false,
    "showline": false,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 0,
    "ticks": "",
    "showticklabels": true,

test/image/mocks/12.json

@@ -376,7 +376,7 @@
    "showgrid": false,
    "zeroline": false,
    "showline": true,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 0,
    "ticks": "",
    "showticklabels": true,
@@ -416,7 +416,7 @@
    "showgrid": false,
    "zeroline": false,
    "showline": true,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 0,
    "ticks": "",
    "showticklabels": true,

test/image/mocks/13.json

@@ -232,7 +232,7 @@
    "showgrid": true,
    "zeroline": true,
    "showline": true,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 13,
    "ticks": "",
    "showticklabels": true,
@@ -272,7 +272,7 @@
    "showgrid": true,
    "zeroline": true,
    "showline": true,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 13,
    "ticks": "",
    "showticklabels": true,

test/image/mocks/14.json

@@ -54,7 +54,7 @@
    "showgrid": true,
    "zeroline": true,
    "showline": false,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 40,
    "ticks": "",
    "showticklabels": true,
@@ -95,7 +95,7 @@
    "showgrid": true,
    "zeroline": true,
    "showline": false,
-   "autotick": true,
+   "tickmode": "auto",
    "nticks": 6,
    "ticks": "",
    "showticklabels": true,