-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
get_google_supported_platform_string which detects the platform architecture to download the chrome build, ignores the arch_detected value on Linux systems. This results in incorrect chrome build being downloaded for aarch64.
choreographer/src/choreographer/cli/_cli_utils.py
Lines 26 to 42 in 3128bdd
| def get_google_supported_platform_string() -> str | None: | |
| arch_size_detected = "64" if sys.maxsize > 2**32 else "32" | |
| arch_detected = "arm" if platform.processor() == "arm" else "x" | |
| chrome_platform_detected: str | None = None | |
| if platform.system() == "Windows": | |
| chrome_platform_detected = "win" + arch_size_detected | |
| elif platform.system() == "Linux": | |
| chrome_platform_detected = "linux" + arch_size_detected | |
| elif platform.system() == "Darwin": | |
| chrome_platform_detected = "mac-" + arch_detected + arch_size_detected | |
| platform_string = "" | |
| if chrome_platform_detected in supported_platform_strings: | |
| platform_string = chrome_platform_detected | |
| return platform_string |
Moreover, platform.processor() returns aarch64 and not arm on my machine, which results in wrong arch_detected value.
Metadata
Metadata
Assignees
Labels
No labels