chore: Remove support for Python 3.8 (#310)

* chore: Remove support for Python 3.8

* Update formatting per 3.9 rules

Author: camdecoster

.github/workflows/publish_testpypi.yml

@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python_v: ['3.8', '3.9', '3.10', '3.12', '3.13', '3.14', '3.14t']
+        python_v: ['3.9', '3.10', '3.12', '3.13', '3.14', '3.14t']
         # chrome_v: ['-1']
     name: Build and Test
     runs-on: ${{ matrix.os }}

.python_version

@@ -1 +1 @@
-3.8
+3.9

CHANGELOG.md

@@ -19,6 +19,9 @@ where X.Y.Z is the semver of the most recent choreographer release.
 - Add `proxy_server` browser configuration with a `CHOREO_PROXY_SERVER` environment fallback [[#304](https://github.com/plotly/choreographer/pull/304)], with thanks to @ColumbusLabs for the contribution!
 - Send `Runtime.callFunctionOn` commands in chunks when they are too big for Chrome's 100MiB devtools buffer [[#306](https://github.com/plotly/choreographer/pull/306)]
 
+### Removed
+- Drop support for Python 3.8 [[#294](https://github.com/plotly/choreographer/pull/294)]
+
 ### Fixed
 - Improve platform architecture detection for arm on Linux and Windows [[#290](https://github.com/plotly/choreographer/pull/290)], with thanks to @juliabeliaeva for the contribution!
 - Fix license file and add a valid SPDX identifier to project settings [[#294](https://github.com/plotly/choreographer/pull/294)], with thanks to @ecederstrand for the contribution!

pyproject.toml

@@ -18,7 +18,7 @@ choreographer = ['resources/last_known_good_chrome.json']
 name = "choreographer"
 description = "Devtools Protocol implementation for chrome."
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = "MIT"
 license-files = [ "LICENSE.md" ]
 dynamic = ["version"]

src/choreographer/_brokers/_async.py

@@ -13,7 +13,8 @@
 # afrom choreographer.channels import ChannelClosedError
 
 if TYPE_CHECKING:
-    from typing import Any, MutableMapping
+    from collections.abc import MutableMapping
+    from typing import Any
 
     from choreographer.browser_async import Browser
     from choreographer.channels._interface_type import ChannelInterface

src/choreographer/browser_async.py

@@ -23,9 +23,10 @@
 from .utils._kill import kill
 
 if TYPE_CHECKING:
+    from collections.abc import Generator, MutableMapping
     from pathlib import Path
     from types import TracebackType
-    from typing import Any, Generator, MutableMapping
+    from typing import Any
 
     from typing_extensions import Self  # 3.9 needs this, could be from typing in 3.10
 

src/choreographer/browser_sync.py

@@ -16,9 +16,10 @@
 from .utils._kill import kill
 
 if TYPE_CHECKING:
+    from collections.abc import MutableMapping
     from pathlib import Path
     from types import TracebackType
-    from typing import Any, MutableMapping
+    from typing import Any
 
     from typing_extensions import Self  # 3.9 needs this, could be from typing in 3.10
 

src/choreographer/browsers/_interface_type.py

@@ -6,8 +6,9 @@
 
 if TYPE_CHECKING:
     import logging
+    from collections.abc import Mapping, MutableMapping, Sequence
     from pathlib import Path
-    from typing import Any, Mapping, MutableMapping, Sequence
+    from typing import Any
 
     from choreographer.channels._interface_type import ChannelInterface
 

src/choreographer/browsers/chromium.py

@@ -26,7 +26,8 @@
 
 if TYPE_CHECKING:
     import logging
-    from typing import Any, Mapping, MutableMapping, Sequence
+    from collections.abc import Mapping, MutableMapping, Sequence
+    from typing import Any
 
     from choreographer.channels._interface_type import ChannelInterface
 

src/choreographer/channels/_interface_type.py

@@ -5,7 +5,8 @@
 from typing import TYPE_CHECKING, Protocol
 
 if TYPE_CHECKING:
-    from typing import Any, Mapping, Sequence
+    from collections.abc import Mapping, Sequence
+    from typing import Any
 
     from choreographer.protocol import BrowserResponse