Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find some problem about include files #1

Open
SegmentationFaultCD opened this issue Feb 24, 2025 · 2 comments
Open

Find some problem about include files #1

SegmentationFaultCD opened this issue Feb 24, 2025 · 2 comments

Comments

@SegmentationFaultCD
Copy link

  1. In file stddef.h, I find that you use typedef to create a type alias, but not use using. And there is a function called unreachable in C++23, you don't have to make a define unreachable .
  2. The project called limine-xmake-cxx-template, but it seems to suppost C language
  3. you should use cstddef to replace stddef.h, use cstdint to replace stdint.h
@SegmentationFaultCD
Copy link
Author

What's more, cstddef and cstdint are freestanding header files, you don't have to provide them.

@wenxuanjun
Copy link
Contributor

These header files were copied directly from the C version of the repository and they are supposed to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants