Update benchmark comments

plokhotnyuk · plokhotnyuk · commit 25cced72d1fd · 2025-01-08T19:00:36.000+01:00
diff --git a/jsoniter-scala-benchmark/js/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala b/jsoniter-scala-benchmark/js/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala
@@ -1602,6 +1602,8 @@ object Main {
       B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
       B("smithy4sJson")(benchmark.smithy4sJson()),
       B("uPickle")(benchmark.uPickle()),
+      //FIXME: zio-json skips serialization of the `"description": {}` field
+      //B("zioJson")(benchmark.zioJson()),
       B("zioSchemaJson")(benchmark.zioSchemaJson())
     ))
   }, {
diff --git a/jsoniter-scala-benchmark/js/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala b/jsoniter-scala-benchmark/js/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala
@@ -1485,6 +1485,8 @@ object Main {
       B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
       B("smithy4sJson")(benchmark.smithy4sJson()),
       B("uPickle")(benchmark.uPickle()),
+      //FIXME: zio-json skips serialization of the `"description": {}` field
+      //B("zioJson")(benchmark.zioJson()),
       B("zioSchemaJson")(benchmark.zioSchemaJson())
     ))
   }, {
diff --git a/jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala b/jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala
@@ -18,7 +18,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {
       toString(b.playJsonJsoniter()) shouldBe b.compactJsonString1
       toString(b.smithy4sJson()) shouldBe b.compactJsonString1
       toString(b.uPickle()) shouldBe b.compactJsonString1
-      //FIXME: zio-json serializes default values
+      //FIXME: zio-json skips serialization of the `"description": {}` field
       //toString(b.zioJson()) shouldBe b.compactJsonString1
       toString(b.zioSchemaJson()) shouldBe b.compactJsonString1
     }
diff --git a/jsoniter-scala-benchmark/js/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala b/jsoniter-scala-benchmark/js/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala
@@ -17,7 +17,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {
       toString(b.playJsonJsoniter()) shouldBe b.compactJsonString1
       toString(b.smithy4sJson()) shouldBe b.compactJsonString1
       toString(b.uPickle()) shouldBe b.compactJsonString1
-      //FIXME: zio-json serializes default values
+      //FIXME: zio-json skips serialization of the `"description": {}` field
       //toString(b.zioJson()) shouldBe b.compactJsonString1
       toString(b.zioSchemaJson()) shouldBe b.compactJsonString1
     }
diff --git a/jsoniter-scala-benchmark/jvm/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala b/jsoniter-scala-benchmark/jvm/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala
@@ -27,7 +27,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {
       toString(b.sprayJson()) shouldBe b.compactJsonString2
       toString(b.uPickle()) shouldBe b.compactJsonString1
       toString(b.weePickle()) shouldBe b.compactJsonString1
-      //FIXME: zio-json serializes default values
+      //FIXME: zio-json skips serialization of the `"description": {}` field
       //toString(b.zioJson()) shouldBe b.compactJsonString1
       toString(b.zioSchemaJson()) shouldBe b.compactJsonString1
     }
diff --git a/jsoniter-scala-benchmark/jvm/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala b/jsoniter-scala-benchmark/jvm/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWritingSpec.scala
@@ -24,7 +24,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {
       toString(b.sprayJson()) shouldBe b.compactJsonString2
       toString(b.uPickle()) shouldBe b.compactJsonString1
       toString(b.weePickle()) shouldBe b.compactJsonString1
-      //FIXME: zio-json serializes default values
+      //FIXME: zio-json skips serialization of the `"description": {}` field
       //toString(b.zioJson()) shouldBe b.compactJsonString1
       toString(b.zioSchemaJson()) shouldBe b.compactJsonString1
     }
diff --git a/jsoniter-scala-benchmark/shared/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWriting.scala b/jsoniter-scala-benchmark/shared/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWriting.scala
@@ -138,7 +138,7 @@ class TwitterAPIWriting extends TwitterAPIBenchmark {
 
     FromScala(obj).transform(ToJson.bytes)
   }
-/* FIXME: zio-json serializes default values
+/* FIXME: zio-json skips serialization of the `"description": {}` field
   @Benchmark
   def zioJson(): Array[Byte] = {
     import com.github.plokhotnyuk.jsoniter_scala.benchmark.ZioJsonCodecs._
diff --git a/jsoniter-scala-benchmark/shared/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWriting.scala b/jsoniter-scala-benchmark/shared/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/TwitterAPIWriting.scala
@@ -122,7 +122,7 @@ class TwitterAPIWriting extends TwitterAPIBenchmark {
 
     FromScala(obj).transform(ToJson.bytes)
   }
-/* FIXME: zio-json serializes default values
+/* FIXME: zio-json skips serialization of the `"description": {}` field
   @Benchmark
   def zioJson(): Array[Byte] = {
     import com.github.plokhotnyuk.jsoniter_scala.benchmark.ZioJsonCodecs._

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {`
`18`	`18`	`toString(b.playJsonJsoniter()) shouldBe b.compactJsonString1`
`19`	`19`	`toString(b.smithy4sJson()) shouldBe b.compactJsonString1`
`20`	`20`	`toString(b.uPickle()) shouldBe b.compactJsonString1`
`21`		`- //FIXME: zio-json serializes default values`
	`21`	+ //FIXME: zio-json skips serialization of the `"description": {}` field
`22`	`22`	`//toString(b.zioJson()) shouldBe b.compactJsonString1`
`23`	`23`	`toString(b.zioSchemaJson()) shouldBe b.compactJsonString1`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {`
`17`	`17`	`toString(b.playJsonJsoniter()) shouldBe b.compactJsonString1`
`18`	`18`	`toString(b.smithy4sJson()) shouldBe b.compactJsonString1`
`19`	`19`	`toString(b.uPickle()) shouldBe b.compactJsonString1`
`20`		`- //FIXME: zio-json serializes default values`
	`20`	+ //FIXME: zio-json skips serialization of the `"description": {}` field
`21`	`21`	`//toString(b.zioJson()) shouldBe b.compactJsonString1`
`22`	`22`	`toString(b.zioSchemaJson()) shouldBe b.compactJsonString1`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {`
`27`	`27`	`toString(b.sprayJson()) shouldBe b.compactJsonString2`
`28`	`28`	`toString(b.uPickle()) shouldBe b.compactJsonString1`
`29`	`29`	`toString(b.weePickle()) shouldBe b.compactJsonString1`
`30`		`- //FIXME: zio-json serializes default values`
	`30`	+ //FIXME: zio-json skips serialization of the `"description": {}` field
`31`	`31`	`//toString(b.zioJson()) shouldBe b.compactJsonString1`
`32`	`32`	`toString(b.zioSchemaJson()) shouldBe b.compactJsonString1`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class TwitterAPIWritingSpec extends BenchmarkSpecBase {`
`24`	`24`	`toString(b.sprayJson()) shouldBe b.compactJsonString2`
`25`	`25`	`toString(b.uPickle()) shouldBe b.compactJsonString1`
`26`	`26`	`toString(b.weePickle()) shouldBe b.compactJsonString1`
`27`		`- //FIXME: zio-json serializes default values`
	`27`	+ //FIXME: zio-json skips serialization of the `"description": {}` field
`28`	`28`	`//toString(b.zioJson()) shouldBe b.compactJsonString1`
`29`	`29`	`toString(b.zioSchemaJson()) shouldBe b.compactJsonString1`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ class TwitterAPIWriting extends TwitterAPIBenchmark {`
`138`	`138`
`139`	`139`	`FromScala(obj).transform(ToJson.bytes)`
`140`	`140`	`}`
`141`		`-/* FIXME: zio-json serializes default values`
	`141`	+/* FIXME: zio-json skips serialization of the `"description": {}` field
`142`	`142`	`@Benchmark`
`143`	`143`	`def zioJson(): Array[Byte] = {`
`144`	`144`	`import com.github.plokhotnyuk.jsoniter_scala.benchmark.ZioJsonCodecs._`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ class TwitterAPIWriting extends TwitterAPIBenchmark {`
`122`	`122`
`123`	`123`	`FromScala(obj).transform(ToJson.bytes)`
`124`	`124`	`}`
`125`		`-/* FIXME: zio-json serializes default values`
	`125`	+/* FIXME: zio-json skips serialization of the `"description": {}` field
`126`	`126`	`@Benchmark`
`127`	`127`	`def zioJson(): Array[Byte] = {`
`128`	`128`	`import com.github.plokhotnyuk.jsoniter_scala.benchmark.ZioJsonCodecs._`