Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNode->modifyVariableId() : useless parameter #30

Open
yunhenk opened this issue Sep 12, 2018 · 0 comments
Open

BNode->modifyVariableId() : useless parameter #30

yunhenk opened this issue Sep 12, 2018 · 0 comments

Comments

@yunhenk
Copy link

yunhenk commented Sep 12, 2018

Hi, i'm learning from your code, and find that the below function seems to have an useless parameter newNodeId,please check it.

	protected void modifyVariableId(String oldNodeId, String newNodeId) {
		if (inputNodes.containsKey(oldNodeId)) {
			BNode inputNode = inputNodes.get(oldNodeId);
			removeInputNode_internal(oldNodeId);
			addInputNode_internal(inputNode);
		}
		else if (outputNodes.containsKey(oldNodeId)) {
			BNode outputNode = outputNodes.get(oldNodeId);
			removeOutputNode_internal(oldNodeId);
			addOutputNode_internal(outputNode);
		}
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant