Skip to content

Commit d328d77

Browse files
committed
prima-ref -> data-prima-ref
1 parent 004084c commit d328d77

File tree

7 files changed

+23
-21
lines changed

7 files changed

+23
-21
lines changed

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ end
6262
```
6363

6464
### Custom Data Attributes
65-
- `prima-ref` - Component instance identifier
65+
- `data-prima-ref` - Component instance identifier
6666
- `data-focus` - Focus state for dropdown items (true/false)
6767
- Standard data attributes for component state management
6868

assets/js/hooks/modal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export default {
141141
},
142142

143143
ref(ref) {
144-
return this.modalEl.querySelector(`[prima-ref="${ref}"]`);
144+
return this.modalEl.querySelector(`[data-prima-ref="${ref}"]`);
145145
},
146146

147147
log(message) {

lib/prima/modal.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ defmodule Prima.Modal do
155155
style="display: none;"
156156
js-show={JS.show(transition: @transition_enter)}
157157
js-hide={JS.hide(transition: @transition_leave)}
158-
prima-ref="modal-overlay"
158+
data-prima-ref="modal-overlay"
159159
class={@class}
160160
>
161161
</div>
@@ -180,7 +180,7 @@ defmodule Prima.Modal do
180180
"""
181181
def modal_loader(assigns) do
182182
~H"""
183-
<div prima-ref="modal-loader" js-show={JS.show()} js-hide={JS.hide()}>
183+
<div data-prima-ref="modal-loader" js-show={JS.show()} js-hide={JS.hide()}>
184184
{render_slot(@inner_block)}
185185
</div>
186186
"""
@@ -248,7 +248,7 @@ defmodule Prima.Modal do
248248
js-focus-first={JS.focus_first()}
249249
phx-mounted={panel_mounted()}
250250
phx-remove={panel_removed()}
251-
prima-ref="modal-panel"
251+
data-prima-ref="modal-panel"
252252
phx-window-keydown={close()}
253253
phx-key="escape"
254254
phx-click-away={close()}
@@ -373,7 +373,7 @@ defmodule Prima.Modal do
373373
def modal_title(assigns) do
374374
assigns =
375375
assign(assigns, %{
376-
"prima-ref": "modal-title"
376+
"data-prima-ref": "modal-title"
377377
})
378378

379379
case assigns[:as] do

lib/prima_web/live/fixtures_live.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ defmodule PrimaWeb.FixturesLive do
6363

6464
defp custom_title_component(assigns) do
6565
~H"""
66-
<span class="custom-title" prima-ref={assigns[:"prima-ref"]} id={assigns[:id]}>
66+
<span class="custom-title" data-prima-ref={assigns[:"data-prima-ref"]} id={assigns[:id]}>
6767
{render_slot(assigns.inner_block)}
6868
</span>
6969
"""

test/wallaby/prima_web/async_modal_test.exs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
defmodule PrimaWeb.AsyncModalTest do
22
use Prima.WallabyCase, async: true
33

4-
@modal_panel Query.css("#demo-form-modal [prima-ref=modal-panel]")
5-
@modal_overlay Query.css("#demo-form-modal [prima-ref=modal-overlay]")
4+
@modal_panel Query.css("#demo-form-modal [data-prima-ref=modal-panel]")
5+
@modal_overlay Query.css("#demo-form-modal [data-prima-ref=modal-overlay]")
66
@modal_container Query.css("#demo-form-modal")
7-
@modal_loader Query.css("#demo-form-modal [prima-ref=modal-loader]")
7+
@modal_loader Query.css("#demo-form-modal [data-prima-ref=modal-loader]")
88

99
feature "shows modal when button is clicked", %{session: session} do
1010
session
@@ -88,7 +88,7 @@ defmodule PrimaWeb.AsyncModalTest do
8888
|> click(Query.css("#open-form-modal-button"))
8989
|> assert_has(@modal_panel |> Query.visible(true))
9090
|> execute_script(
91-
"document.querySelector('#demo-form-modal [prima-ref=\"modal-title\"]').innerHTML = 'Dirty Modal'"
91+
"document.querySelector('#demo-form-modal [data-prima-ref=\"modal-title\"]').innerHTML = 'Dirty Modal'"
9292
)
9393
|> send_keys([:escape])
9494
|> assert_has(@modal_container |> Query.visible(false))
@@ -98,7 +98,7 @@ defmodule PrimaWeb.AsyncModalTest do
9898
|> assert_has(@modal_panel |> Query.visible(true))
9999
# Verify the fresh content eventually appears
100100
|> assert_text(
101-
Query.css("#demo-form-modal [prima-ref=\"modal-title\"]"),
101+
Query.css("#demo-form-modal [data-prima-ref=\"modal-title\"]"),
102102
"Data loaded successfully"
103103
)
104104
|> execute_script("window.liveSocket.disableLatencySim()")

test/wallaby/prima_web/modal_title_test.exs

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@ defmodule PrimaWeb.ModalTitleTest do
33
import Phoenix.LiveViewTest
44

55
@modal_container Query.css("#demo-modal")
6-
@modal_title Query.css("#demo-modal [prima-ref=modal-title]")
6+
@modal_title Query.css("#demo-modal [data-prima-ref=modal-title]")
77

88
feature "modal title renders as h3 by default", %{session: session} do
99
session
1010
|> visit_fixture("/fixtures/simple-modal", "#demo-modal")
1111
|> click(Query.css("#simple-modal button"))
1212
|> assert_has(@modal_container |> Query.visible(true))
1313
|> assert_has(@modal_title)
14-
|> assert_has(Query.css("#demo-modal h3[prima-ref=modal-title]"))
15-
|> assert_has(Query.css("#demo-modal h3[prima-ref=modal-title]", text: "Good news"))
14+
|> assert_has(Query.css("#demo-modal h3[data-prima-ref=modal-title]"))
15+
|> assert_has(Query.css("#demo-modal h3[data-prima-ref=modal-title]", text: "Good news"))
1616
end
1717

1818
feature "modal title can render as custom HTML tag", %{session: session} do
@@ -22,8 +22,10 @@ defmodule PrimaWeb.ModalTitleTest do
2222
|> click(Query.css("#custom-tag-modal button"))
2323
|> assert_has(@modal_container |> Query.visible(true))
2424
|> assert_has(@modal_title)
25-
|> assert_has(Query.css("#demo-modal h1[prima-ref=modal-title]"))
26-
|> assert_has(Query.css("#demo-modal h1[prima-ref=modal-title]", text: "Custom Tag Title"))
25+
|> assert_has(Query.css("#demo-modal h1[data-prima-ref=modal-title]"))
26+
|> assert_has(
27+
Query.css("#demo-modal h1[data-prima-ref=modal-title]", text: "Custom Tag Title")
28+
)
2729
end
2830

2931
feature "modal title can render as function component", %{session: session} do
@@ -33,9 +35,9 @@ defmodule PrimaWeb.ModalTitleTest do
3335
|> click(Query.css("#function-modal button"))
3436
|> assert_has(@modal_container |> Query.visible(true))
3537
|> assert_has(@modal_title)
36-
|> assert_has(Query.css("#demo-modal span[prima-ref=modal-title].custom-title"))
38+
|> assert_has(Query.css("#demo-modal span[data-prima-ref=modal-title].custom-title"))
3739
|> assert_has(
38-
Query.css("#demo-modal span[prima-ref=modal-title]", text: "Function Component Title")
40+
Query.css("#demo-modal span[data-prima-ref=modal-title]", text: "Function Component Title")
3941
)
4042
end
4143

test/wallaby/prima_web/simple_modal_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
defmodule PrimaWeb.SimpleModalTest do
22
use Prima.WallabyCase, async: true
33

4-
@modal_panel Query.css("#demo-modal [prima-ref=modal-panel]")
5-
@modal_overlay Query.css("#demo-modal [prima-ref=modal-overlay]")
4+
@modal_panel Query.css("#demo-modal [data-prima-ref=modal-panel]")
5+
@modal_overlay Query.css("#demo-modal [data-prima-ref=modal-overlay]")
66
@modal_container Query.css("#demo-modal")
77

88
feature "shows modal when button is clicked", %{session: session} do

0 commit comments

Comments
 (0)