-
Notifications
You must be signed in to change notification settings - Fork 161
2.8.1 does not work on Atom 1.26.0 Windows 10 32bit #514
Comments
same problem on this version ! |
My instance is also not working. I get a flashing cursor without the ability to type anything. Atom 1.26.0 Windows 10 64bit |
You guys that dont have this working, have you tried uninstalling the platformIO-ide-terminal and reinstalling it again? What about uninstalling atom and reinstalling it again also? If not try https://atom.io/packages/termination and see if that fairs better,. A personal observation about this project, at this rate of labelling by author @ivankravets PR Welcome and amount of commits and activity being minimal, suggests that he is either too busy with real life, or, he is not inclined to invest time on this project investigating and fixing anything himself any time soon. Even the PR's open are months old, so that suggests hes likely too busy to handle the project. |
/cc @nathansobo @as-cii |
Thanks for the update. it happens, its sad, but it happens, |
@ivankravets that will never happen atom/atom#12649 They explicitly said that they wont maintain it, so that leaves us in the dry from both fronts there is currently no maintained versions of a terminal, they are all flaky and buggy as hell this was the best option so far and also no longer even maintained.
@ivankravets None of this seems even close to reality, PR's are left without review and hanging for months and current functionality is clearly going flaky with newer atom versions. PR welcome yea, more like fork welcome.
|
Hi everyone, |
How do you plan to maintain it? We don't have the useful PRs to this repository, see https://github.com/platformio/platformio-atom-ide-terminal/pulls. If you plan that someone fixes issues and you merge PRs, it will not work. We need strong code review before merging something new. I'm opened for PR and can review them. |
@ivankravets You have two bug fixes gathering cobwebs, is that not useful? Slightly unfair comment there.
Really, have you reviewed the open PR's? The bug fixes at least? Nope #525 not reviewed, fixes stuff and its there waiting for? What about the other PRs? If you arent going to merge them new features close them. IDK, I appreciate the existence o PIO but making claims is nice when backed by actionable verifiable info. Sorry to say Not meant to offend. |
@ivankravets good question, and I don't know for certain. Over time I would like to find collaborators who are dedicated, and then giving them full commit access so it becomes less my project and more a community-backed thing. But that's definitely not something I can count on. Possibly termination will end up the same way, maintenance but not actively developed. Strangely enough, I've been mulling over seeing if I could open a few PRs here to allow your project to (optionally) look more like the old terminal-plus, and then closing up shop. I'm not critizing your decision to quit actively developing this, but I wouldn't want to do that without active development (instead of just merging PRs). |
Optionally, phew OK, I like PIO how it looks and how it integrates with atom, something your project and terminal-plus was meant to integrate with very earlier version of atom and look out of place now, sorry to say. I can tell you from experience that maintaining a project usable as a non coder is very time intensive to look ACTIVELY for developers who are willing at least to make a fix every so often. Otherwise its just just another dead fork. Perhaps you can try talking to the people who made PR's here. But that leaves tons of code to handle from your side.
Waste of time, your better to reverse the flow, take code from here since MIT lic what else do you need? |
Haha, no worries. I didn't like PIO terminal as much when running in ordinary Atom (no offence @ivankravets ) so it looks more like terminal-plus. It can be made to look like PIO terminal though with the terminal icons and etc all on the left side by un-ticking the "Clone Terminal-Plus" box: EDIT: regarding your other points. |
Thank you so much for all contributions! v2.8.2 is out! 👍 |
Please retest again with platformio-atom-ide-terminal 2.9.0 these type issue all so far seem fixed with this release due to using node-pty-prebuilt instead unmaintained and outdated pty.js |
Flashing cursor only, can't type.
2.8.1 does not work on Atom 1.26.0 Windows 10 32bit
The text was updated successfully, but these errors were encountered: