Skip to content

Commit e8e7d8f

Browse files
committed
Preparing for napi-rs v3
1 parent 4030374 commit e8e7d8f

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

crates/php_node/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ path = "src/lib.rs"
99

1010
[dependencies]
1111
# Default enable napi4 feature, see https://nodejs.org/api/n-api.html#node-api-version-matrix
12-
napi = { version = "2.12.2", default-features = false, features = ["napi4"] }
13-
napi-derive = "2.12.2"
12+
napi = { version = "3.0.0-beta.3", default-features = false, features = ["napi4"] }
13+
napi-derive = "3.0.0-beta.3"
1414
php = { path = "../php" }
1515

1616
[build-dependencies]

crates/php_node/src/headers.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,13 +305,13 @@ impl PhpHeaders {
305305
/// });
306306
/// ```
307307
#[napi]
308-
pub fn for_each<F: Fn(String, String, &This) -> Result<()>>(
308+
pub fn for_each<F: Fn(String, String, This) -> Result<()>>(
309309
&self,
310310
this: This,
311311
callback: F,
312312
) -> Result<()> {
313313
for entry in self.entries() {
314-
callback(entry.1, entry.0, &this)?;
314+
callback(entry.1, entry.0, this)?;
315315
}
316316
Ok(())
317317
}

index.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export interface PhpOptions {
5656
/** Throw request errors */
5757
throwRequestErrors?: boolean
5858
}
59+
undefinedundefined
5960
export type PhpHeaders = Headers
6061
/**
6162
* A multi-map of HTTP headers.
@@ -222,7 +223,7 @@ export declare class Headers {
222223
* }
223224
* ```
224225
*/
225-
entries(): Array<Entry>
226+
entries(): Array<Entry<string, string>>
226227
/**
227228
* Get an iterator over the header keys.
228229
*

0 commit comments

Comments
 (0)