Skip to content

Commit 6a9033d

Browse files
committed
fix urls 2?
Signed-off-by: Nelo-T. Wallus <[email protected]> Signed-off-by: Nelo-T. Wallus <[email protected]>
1 parent 09ba7e7 commit 6a9033d

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

.github/workflows/pages.yaml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ permissions:
1818
contents: write # to write the built page to the branch
1919
pull-requests: write # to leave a comment with the preview URL
2020

21-
env:
22-
PAGES_BASE: ${{ github.event_name == 'pull_request' && format('pr-preview/pr-{0}', github.event.pull_request.number) || '/' }}
23-
2421
concurrency:
2522
# set separate concurrency groups for main and PR branches
2623
group: ${{ github.event_name == 'pull_request' && format('pages-preview-{0}', github.event.pull_request.number) || 'pages-main' }}
@@ -54,19 +51,15 @@ jobs:
5451

5552
- run: npm ci
5653
- run: npm run build
54+
env:
55+
PAGES_BASE: ${{ github.event_name == 'pull_request' && format('pr-preview/pr-{0}', github.event.pull_request.number) || '/' }}
5756

5857
# deploy the PR to a preview URL
5958
- uses: rossjrw/pr-preview-action@9f77b1d057b494e662c50b8ca40ecc63f21e0887 # v1
6059
if: ${{ github.event_name == 'pull_request' }}
6160
with:
6261
source-dir: .vitepress/dist
6362

64-
# - uses: thollander/actions-comment-pull-request@v3
65-
# if: github.event_name == 'pull_request'
66-
# with:
67-
# message: |
68-
# A preview has been deployed to ${{ format('{0}/{1}', steps.configure.outputs.base_url, env.PAGES_BASE) }}
69-
7063
# deploy the build to GitHub Pages
7164
- uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4
7265
if: ${{ (github.event_name == 'push' || github.event_name == 'workflow_dispatch') && github.ref == 'refs/heads/main' }}

.vitepress/config.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { fileURLToPath, URL } from 'node:url'
55
export default withMermaid({
66
title: "Platform Mesh",
77

8-
// base: process.env.PAGES_BASE ? process.env.PAGES_BASE : '/',
8+
base: process.env.PAGES_BASE ? process.env.PAGES_BASE : '/',
99

1010
description: "Platform Mesh - Building upon the Kubernetes API & Resource Model",
1111

0 commit comments

Comments
 (0)