You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
Is your feature request related to a problem? Please describe.
It seems we may be running into problems with submitRootHash() being called, not completing, and then being called again. Because we are not providing any nonce management, this is sure to cause issues.
Note that I just copied and pasted the code from block-manager and changed variable names. Probably should extract this logic into some kind of library & share code between them.
Describe alternatives you've considered
Eventually we probably want to store every transaction that is sent out of the operator & the latest nonce. This way we can have a full history of transactions which are sent and can ensure that we never send two txs with the same nonce. And if one tx we signed isn't getting through, we can add logic for rebroadcasting.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
It seems we may be running into problems with
submitRootHash()
being called, not completing, and then being called again. Because we are not providing any nonce management, this is sure to cause issues.Describe the solution you'd like
A very simple temporary fix is adding a
submitRootHashQueue
similar to the one found in https://github.com/plasma-group/plasma-chain-operator/blob/master/src/block-manager/block-store.js#L51-L59 . The code would be something like:Note that I just copied and pasted the code from
block-manager
and changed variable names. Probably should extract this logic into some kind of library & share code between them.Describe alternatives you've considered
Eventually we probably want to store every transaction that is sent out of the operator & the latest nonce. This way we can have a full history of transactions which are sent and can ensure that we never send two txs with the same nonce. And if one tx we signed isn't getting through, we can add logic for rebroadcasting.
The text was updated successfully, but these errors were encountered: