Fix: If the translation is in the Popup, cancel when the window is closed

Author: plaintool

forms/formpopup.pas

@@ -90,7 +90,7 @@   TformPopupTrayslate = class(TForm)
 
 implementation
 
-uses consts, mainform, localize, darkutils, controlshelper;
+uses Consts, mainform, localize, darkutils, controlshelper;
 
   {$R *.lfm}
 
@@ -130,6 +130,10 @@ procedure TformPopupTrayslate.FormShow(Sender: TObject);
 procedure TformPopupTrayslate.FormHide(Sender: TObject);
 begin
   FDropTarget.Unregister;
+
+  if Assigned(formTrayslate.TranslateTarget) and (formTrayslate.TranslateTarget is TMemo) and
+    (formTrayslate.TranslateTarget = MemoTarget) then
+    formTrayslate.CancelTranslate;
 end;
 
 procedure TformPopupTrayslate.FormShortCut(var Msg: TLMKey; var Handled: boolean);

forms/mainform.pas

@@ -360,6 +360,7 @@   TformTrayslate = class(TForm)
     FPopupRecentPair: TComponent;
     FRawTranslate: string;
     FSettingsPage: integer;
+    FTranslateTarget: TWinControl;
 
     // Non sorted combo named languages
     FLanguages: TStringList;
@@ -594,6 +595,7 @@   TformTrayslate = class(TForm)
     property LastDarkMode: boolean read FLastDarkMode write FLastDarkMode;
     property CustomPoFile: string read FCustomPoFile write FCustomPoFile;
     property RawTranslate: string read FRawTranslate write FRawTranslate;
+    property TranslateTarget:TWinControl read FTranslateTarget;
     property MouseHook: TGlobalMouseHook read FMouseHook write FMouseHook;
     property KeyHook: TGlobalKeyboardHook read FKeyHook write FKeyHook;
     property HotKeyApp: THotKeyData read FHotKeyApp write FHotKeyApp;
@@ -3932,6 +3934,7 @@ function TformTrayslate.TranslateThread(ATrans: TTranslate; AText: string; AMemo
     Th := TTranslateThread.Create(ATrans, False);
     FTranslateThread := Th;
     FActiveThreads.Add(Th);
+    FTranslateTarget := AMemo;
     UpdateTranslateButtonState;
     Screen.Cursor := crAppStart;
     TimerAnimate.Enabled := True;
@@ -3989,6 +3992,8 @@ procedure TformTrayslate.ThreadDone(Sender: TObject);
 
   if not Visible and (not Assigned(formPopupTrayslate) or not formPopupTrayslate.Visible) then
     ShowCustomHint(TrayIcon.Hint);
+
+  FTranslateTarget := nil;
 end;
 
 procedure TformTrayslate.CancelTranslate;
@@ -4000,6 +4005,7 @@ procedure TformTrayslate.CancelTranslate;
       FTranslateThread := nil;
     end;
     FCancelled := True;
+    FTranslateTarget := nil;
   finally
     UpdateTranslateButtonState;
     TimerAnimate.Enabled := False;