Improved handling of threads

Author: plaintool

forms/mainform.pas

@@ -3966,6 +3966,7 @@ function TformTrayslate.TranslateThread(ATrans: TTranslate; AText: string; AMemo
     UpdateTranslateButtonState;
     Screen.Cursor := crAppStart;
     TimerAnimate.Enabled := True;
+    Th.Start;
     try
       while Assigned(Th) and (not Th.Finished) do
       begin
@@ -3992,8 +3993,10 @@ function TformTrayslate.TranslateThread(ATrans: TTranslate; AText: string; AMemo
     finally
       if Assigned(Th) then
       begin
-        Th.Free;   // Th is nil if the thread was replaced/force-killed
         FActiveThreads.Remove(Th);
+        if not Th.Finished then
+          Th.WaitFor;
+        Th.Free;   // Th is nil if the thread was replaced/force-killed
       end;
       FTranslateThread := nil;   // always clear shared reference
     end;

units/translate.pas

@@ -1761,7 +1761,6 @@ constructor TTranslateThread.Create(ATrans: TTranslate; AFreeOnTerminate: boolea
   FTrans := ATrans;
   FSourceText := FTrans.TextToTranslate;
   FCancelled := False;
-  Start;
 end;
 
 destructor TTranslateThread.Destroy;