-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: New 🌈 Color change broke pixi-spine tint #9277
Comments
@SerG-Y we need a repo on this. I tried using the public examples and applying a tint and it did what I would expect. |
@bigtimebuddy I will try to investigate it a bit more if not I will back with repo. |
Hi @bigtimebuddy, can you please tag someone who can take a look at my PR. Thanks! |
I think the better fix here is replace |
@bigtimebuddy I think a deep-equality will not help here. Because |
Maybe we can deep copy the value when setting it. |
@SuperSodaSea sounds good! |
@miltoncandelero in this case can you please revert my commit from pixi-spine as it's not needed anymore. |
Deprecates the following color utilities (#9061) @bigtimebuddy |
Current Behavior
It's hard to explain :) Actually, it's better to compare the images.
I am pretty sure it's related to these two lines in SpineBase:
https://github.com/pixijs/spine/blob/7903e9dae81a855a6725d13789f31ca70260ede8/packages/base/src/SpineBase.ts#L328
https://github.com/pixijs/spine/blob/7903e9dae81a855a6725d13789f31ca70260ede8/packages/base/src/SpineBase.ts#L386
Do you have any idea why it broke pixi-spine?
Expected Behavior
Steps to Reproduce
I think it's easy to reproduce with any spine project that has tint stuff
Environment
pixi.js
version: 7.2.0pixi-spine
version: 4.0.3Possible Solution
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: