-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@pixi-spine/all-4.0 - AnimationStateListener functions should be optional #412
Comments
Its the same as in https://github.com/EsotericSoftware/spine-runtimes/blob/db92cb3667c88bb819bd24c09f839529e0df4aa5/spine-ts/spine-core/src/AnimationState.ts#L1096-L1116 If you think it can be optional, you can make PR's both here and in main repo |
Hi Ivan, thanks for the response. I noticed they weren't optional in https://github.com/EsotericSoftware/spine-runtimes, but they also weren't optional in their 3.8 branch, so I thought you may be doing something custom here. I was going to make a PR, but I'm not exactly sure where the code for the @pixi-spine/runtime-4.0 package is. |
Great, thanks, I was looking the bundles dir. :| I'll make a PR soon. |
Is there any chance this fix could be released through NPM? We've just swapped to Spine 4.0 and we're now seeing this issue using the current latest (3.0.13) of @pixi-spine/all-4.0, would save us some |
state.addListener
, adding a listener to an individual track works as expected.@pixi-spine/all-4.0
-@pixi-spine/all-3.8
, and the mainpixi-spine
package work as expected.Due to this, code like this will not work, since all the functions have to be present:
I've tested that it works by casting the listener to AnimationStateListener, so we know the runtime isn't calling functions that aren't defined.
In @pixi-spine/all-3.8 (correct)
in @pixi-spine/all-4.0 (all functions should be optional as in 3.8)
The text was updated successfully, but these errors were encountered: