Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification of max commission change rate in IPTokenStaking #491

Open
jdubpark opened this issue Feb 27, 2025 · 0 comments
Open

Add verification of max commission change rate in IPTokenStaking #491

jdubpark opened this issue Feb 27, 2025 · 0 comments
Assignees
@Ramarti

Comments

@jdubpark
Copy link
Contributor

Description and context

Following the issue reported in #488 and the corresponding CLI fix in #489, add the verification of the max commission change rate value in the IPTokenStaking contract directly.

Suggested solution

Require maxCommissionChangeRate <= maxCommissionRate in _createValidator function.

Definition of done

With an invalid commission (maxCommissionChangeRate > maxCommissionRate), the tx should fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ramarti Ramarti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ramarti @jdubpark