Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11877] Improved Agent initialization #11899

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 3, 2025

[#noissue] Cleanup PluginTest

@emeroad emeroad added this to the 3.1.0 milestone Jan 3, 2025
@emeroad emeroad linked an issue Jan 3, 2025 that may be closed by this pull request
@emeroad emeroad force-pushed the #11877_agent_classloader branch from 49762a9 to f27d7ec Compare January 3, 2025 07:37
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 31.20000% with 258 lines in your changes missing coverage. Please review.

Project coverage is 37.25%. Comparing base (f3b008d) to head (3687088).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
.../com/navercorp/pinpoint/profiler/DefaultAgent.java 0.00% 52 Missing ⚠️
...a/com/navercorp/pinpoint/profiler/AgentOption.java 42.42% 19 Missing ⚠️
.../navercorp/pinpoint/bootstrap/PinpointStarter.java 0.00% 17 Missing ⚠️
...pinpoint/bootstrap/config/PropertyLoaderUtils.java 0.00% 17 Missing ⚠️
...npoint/bootstrap/config/ProfilePropertyLoader.java 0.00% 16 Missing ⚠️
.../navercorp/pinpoint/profiler/config/LogConfig.java 0.00% 15 Missing ⚠️
...ercorp/pinpoint/profiler/name/AgentProperties.java 0.00% 14 Missing ⚠️
...t/profiler/test/MockApplicationContextFactory.java 0.00% 13 Missing ⚠️
...ercorp/pinpoint/profiler/test/PluginTestAgent.java 0.00% 13 Missing ⚠️
...ercorp/pinpoint/profiler/name/AgentIdResolver.java 0.00% 11 Missing ⚠️
... and 26 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11899      +/-   ##
============================================
- Coverage     37.37%   37.25%   -0.13%     
+ Complexity    12656    12617      -39     
============================================
  Files          4149     4152       +3     
  Lines        100727   100781      +54     
  Branches      10483    10478       -5     
============================================
- Hits          37651    37547     -104     
- Misses        60037    60201     +164     
+ Partials       3039     3033       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad force-pushed the #11877_agent_classloader branch 3 times, most recently from e2f51dc to c0ff703 Compare January 3, 2025 10:00
@emeroad emeroad force-pushed the #11877_agent_classloader branch from c0ff703 to 3687088 Compare January 6, 2025 01:52
@emeroad emeroad merged commit cda0888 into pinpoint-apm:master Jan 6, 2025
1 of 3 checks passed
@emeroad emeroad deleted the #11877_agent_classloader branch January 6, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Agent initialization
1 participant