-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating for v9 #3
Comments
The default is one year to date, and I think that is sufficient. This package shows very limited usage -- https://npm-stat.com/charts.html?package=%40pinojs%2Fjson-colorizer&from=2022-08-27&to=2023-08-27 I also don't see any of the Pino packages depending on this one -- https://www.npmjs.com/package/@pinojs/json-colorizer?activeTab=dependents From the commit history, it looks like @capaj created this fork and contributed it to the org. I'd like to hear if they remember the reasoning, and if they think it should continue to exist. I'd also like to hear @mcollina's opinion. My opinion is that this should be decommissioned (archived in GitHub) and marked as deprecated on npm. |
I changed dependency from chalk to colorette because it is faster and then moved the repo to pinojs org. pinojs/pino-pretty#229 (comment)
I am not sure what you are talking about here. Can you specify? |
As shown above, it is not currently used by any Pino project. Given the lack of maintenance of this package, and the lack of usage in other org projects, I think we are better off reducing our burden. |
Oh right. Feel free to transfer the package back to me or archive it. |
@Ranieri93 we haven't heard @mcollina's opinion yet. |
Oh, you're entirely correct! Let's hear @mcollina! |
It would be great if we could have colorized output of JavaScript objects in pino-pretty. However a PR to do that never materialized. I think we should ideally do that instead of archiving/transfering. |
Okay, I have created the |
Hey @jsumners, I would like to start working on this.
Thank you so much in advance! |
No, that should be all. The only catch is to make sure we can actually use the latest versions. Some dependencies have shifted to ESM only, and that won't work. Such dependencies would need to be pinned to the latest version that is non-ESM.
This means removing the CI configuration for any version of Node less than 18. It can also mean going through the code and removing/updating any blocks that specifically tagged as something like "for Node X support".
I would remove Travis and migrate it to GitHub Actions.
That would be nice in order to keep thing consistent across the org. But it is definitely not a hard requirement. |
Should we consider this as done? |
I think so. |
Thank you @Ranieri93. |
👋 I'm Ranieri, I stumbled upon issue #1762, and I figured that I could help!
Could you provide me some additional informations?
Like what is a suitable number of commits to measure interest? Do you have in mind a range of dates to inspect data coming from npm-stat.com?
Regarding the second point I never worked with CI configs or with
Tap
testing suite, but I can learn!I'm also totally new to Open Source in general, so I hope you'll excuse me if I don't know some procedures or steps, but I'll help as much as I can!
@jsumners
The text was updated successfully, but these errors were encountered: