From af4fcc2b2ae88477d11813ec63a8b2a2d2fa4012 Mon Sep 17 00:00:00 2001
From: Damian Yerrick <git@pineight.com>
Date: Tue, 30 Oct 2018 21:23:00 -0400
Subject: [PATCH] make rolling noise quieter

---
 06-audio/audio_brainstorming.md | 10 ++++++++++
 src/audio.z80                   | 16 ++++++++--------
 src/global.inc                  |  2 +-
 3 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/06-audio/audio_brainstorming.md b/06-audio/audio_brainstorming.md
index 0f26710..6a2ada3 100644
--- a/06-audio/audio_brainstorming.md
+++ b/06-audio/audio_brainstorming.md
@@ -99,3 +99,13 @@ be used in the same segment, as segment header codes $F0-$FF are
 reserved.  This is why quick parameters are assigned such that either
 3 is not used or not used with a deep parameter.  Pulse duty 3 is
 redundant, and muted triangle needs no wave change.
+
+Showing it off
+--------------
+A GIF is inadequate when asking for feedback on sound effects.
+Fortunately, bgb can save audio to an uncompressed wave file
+and video in whatever VFW codec is installed.
+
+    ffmpeg -i bgb-1540876262.avi -i bgb-1540876262.wav \
+      -s 320x288 -sws_flags neighbor -pix_fmt yuv420p \
+      libbet.mp4
diff --git a/src/audio.z80 b/src/audio.z80
index 2686471..dc59d16 100644
--- a/src/audio.z80
+++ b/src/audio.z80
@@ -41,8 +41,8 @@ sfx_table:
   dw fx_launch
 
 fx_roll:
-  db ENVF_DPAR|ENVF_PITCH|1, $4A, $5E
-  db ENVF_DPAR|ENVF_PITCH|7, $50, $54
+  db ENVF_DPAR|ENVF_PITCH|1, $1A, $5E
+  db ENVF_DPAR|ENVF_PITCH|7, $20, $54
   if TEST_PNOISE_BUG
     db ENVF_PITCH|5, $4F
   else
@@ -52,13 +52,13 @@ fx_roll:
   db ENVF_PITCH|5, $47
   db ENVF_PITCH|7, $54
   db ENVF_PITCH|2, $55
-  db ENVF_DPAR|ENVF_PITCH|1, $52, $5E
+  db ENVF_DPAR|ENVF_PITCH|1, $22, $5E
   db ENVF_PITCH|1, $57
   db $FF
 fx_rolltojump:
-  db ENVF_DPAR|ENVF_PITCH|1, $4A, $5E
-  db ENVF_DPAR|ENVF_PITCH|2, $50, $54
-  db ENVF_PITCH|2, $25
+  db ENVF_DPAR|ENVF_PITCH|1, $1A, $5E
+  db ENVF_PITCH|2, $54
+  db ENVF_DPAR|ENVF_PITCH|2, $50, $25
   db $FF
 fx_jump:
   db ENVF_DPAR|ENVF_PITCH|$80, $59, 45
@@ -73,8 +73,8 @@ fx_jump:
 fx_land:
   db ENVF_DPAR|ENVF_PITCH|0, $C1, $24
   db ENVF_PITCH|1, $46
-  db ENVF_DPAR|ENVF_PITCH|11, $67, $54
-  db ENVF_DPAR|ENVF_PITCH|3, $63, $5D
+  db ENVF_DPAR|ENVF_PITCH|11, $63, $54
+  db ENVF_DPAR|ENVF_PITCH|3, $25, $5D
   db ENVF_PITCH|1, $56
   db ENVF_PITCH|1, $57
   db $FF
diff --git a/src/global.inc b/src/global.inc
index 71777c3..568818a 100644
--- a/src/global.inc
+++ b/src/global.inc
@@ -62,6 +62,6 @@ FORCE_FLOOR_SIZE equ 0
 
 ; There's a bug in BGB's implementation of 127-step noise.
 ; GB stops a noise early under certain conditions; BGB does not.
-TEST_PNOISE_BUG equ 1
+TEST_PNOISE_BUG equ 0
 
   ENDC