VRAM leak in either decorations or Snowcap

[ildar]

Describe the bug

after ~1 week of running Pinncale:

$ free -h
               total        used        free      shared  buff/cache   available
Mem:            15Gi       6,1Gi       1,4Gi       6,8Gi       8,0Gi       3,3Gi
Swap:           15Gi       8,1Gi       7,9Gi
$  grep Shmem: /proc/meminfo 
Shmem:           7099500 kB
$  awk '/(drm mm object)|i915/ { hypidx = index($1, "-"); from = substr($1, 1, hypidx - 1); to = substr($1, hypidx + 1); sum += strtonum("0x" to) - strtonum("0x" from) } END { print sum }'  /proc/`pidof pinnacle`/maps
11481280512

Because of this I need to logout and start Pinncale again. Then Shmem comes to normal <1MB.

Reproduction steps

Nothing special. Just run usual programs in Pinnacle

Relevant parts of config

None. Default config behaves the same.

Version info

pinnacle 0.2.0-alpha.1

Build Info:
Build profile: release
rustc version: 1.91.0
Branch: VERGEN_IDEMPOTENT_OUTPUT
Commit: VERGEN_IDEMPOTENT_OUTPUT (VERGEN_IDEMPOTENT_OUTPUT)

Distro

ALTLinux

GPU

Intel Corporation HD Graphics 620 (rev 02)

Config language

Lua

[ildar]

The easy way to reproduce:

1. Running Pinnacle from the Wayland session (Wayland in Wayland) works here.
2. Use no config (makes Pinnacle use default config)
3. Run this:

for i in seq 20; do WAYLAND_DISPLAY=wayland-2 yad --text-info --timeout=1 & done ; fg ; free -h

Every run of the above adds ~0.2 GB to the occupied shared memory.

[Ottatop]

Ok I've had some time to investigate this and we appear to be leaking VRAM in two different areas: 1) holding dead wl surface resources, and 2) either decorations or Snowcap in general. The first is solved by 0693232. I'm confused on why decorations are leaking VRAM, though. As far as I can tell we're using software buffers for those, but VRAM is still being allocated and not being freed. If you turn off decorations you should stop running into this issue.

[Ph4ntomas]

@Ottatop at some point while working on popups I noticed a very slow leak when running winit on X.Org, everytime the mouse hovered over some text.

My guess is that it's surface damage related, but since I found the source of the leak I was looking for and was unable to observe it cleanly on pinnacle proper, I did not inverstigate further.

I wanted to have a clear reproduction before reporting it, but maybe it's linked to the decoration issue ?

[ildar]

@Ottatop , thanks a lot!
I just tested and see Shmem is indeed reclaimed. That's really a great thing for Christmas ))
Now I hope Pinnacle can be not just a daily driver but also a week-long or even a month long :-D
I have windows frames on but no titles and no Snowcap-driven elements persistent. So I'll report back in a week period or earlier.