Merge pull request #350 from pinnacle-comp/focus-border

Add focus borders

Author: Ottatop

api/lua/examples/default/default_config.lua

@@ -348,10 +348,19 @@ Pinnacle.setup(function()
     -- Other stuff       --
     -----------------------
 
-    -- There are no server-side decorations yet, so request all clients use client-side decorations.
-    Window.add_window_rule(function(window)
-        window:set_decoration_mode("client_side")
-    end)
+    -- Enable focus borders
+    if Snowcap then
+        -- Add borders to already existing windows
+        for _, win in ipairs(Window.get_all()) do
+            Snowcap.integration.focus_border_with_titlebar(win):decorate()
+        end
+
+        -- Add borders to new windows
+        Window.add_window_rule(function(window)
+            window:set_decoration_mode("server_side")
+            Snowcap.integration.focus_border_with_titlebar(window):decorate()
+        end)
+    end
 
     -- Enable sloppy focus
     Window.connect_signal({

api/lua/pinnacle/grpc/defs.lua

@@ -1097,6 +1097,13 @@ local pinnacle_window_v1_DecorationMode = {
 ---@class pinnacle.signal.v1.WindowFocusedResponse
 ---@field window_id integer?
 
+---@class pinnacle.signal.v1.WindowTitleChangedRequest
+---@field control pinnacle.signal.v1.StreamControl?
+
+---@class pinnacle.signal.v1.WindowTitleChangedResponse
+---@field window_id integer?
+---@field title string?
+
 ---@class pinnacle.signal.v1.TagActiveRequest
 ---@field control pinnacle.signal.v1.StreamControl?
 
@@ -1463,6 +1470,8 @@ pinnacle.signal.v1.WindowPointerLeaveRequest = {}
 pinnacle.signal.v1.WindowPointerLeaveResponse = {}
 pinnacle.signal.v1.WindowFocusedRequest = {}
 pinnacle.signal.v1.WindowFocusedResponse = {}
+pinnacle.signal.v1.WindowTitleChangedRequest = {}
+pinnacle.signal.v1.WindowTitleChangedResponse = {}
 pinnacle.signal.v1.TagActiveRequest = {}
 pinnacle.signal.v1.TagActiveResponse = {}
 pinnacle.signal.v1.InputDeviceAddedRequest = {}
@@ -2653,6 +2662,27 @@ pinnacle.signal.v1.SignalService.WindowFocused.response = ".pinnacle.signal.v1.W
 function Client:pinnacle_signal_v1_SignalService_WindowFocused(callback)
     return self:bidirectional_streaming_request(pinnacle.signal.v1.SignalService.WindowFocused, callback)
 end
+pinnacle.signal.v1.SignalService.WindowTitleChanged = {}
+pinnacle.signal.v1.SignalService.WindowTitleChanged.service = "pinnacle.signal.v1.SignalService"
+pinnacle.signal.v1.SignalService.WindowTitleChanged.method = "WindowTitleChanged"
+pinnacle.signal.v1.SignalService.WindowTitleChanged.request = ".pinnacle.signal.v1.WindowTitleChangedRequest"
+pinnacle.signal.v1.SignalService.WindowTitleChanged.response = ".pinnacle.signal.v1.WindowTitleChangedResponse"
+
+---Performs a bidirectional-streaming request.
+---
+---`callback` will be called with every streamed response.
+---
+---The raw client-to-server stream is returned to allow you to send encoded messages.
+---
+---@nodiscard
+---
+---@param callback fun(response: pinnacle.signal.v1.WindowTitleChangedResponse, stream: grpc_client.h2.Stream)
+---
+---@return grpc_client.h2.Stream | nil
+---@return string | nil An error string, if any
+function Client:pinnacle_signal_v1_SignalService_WindowTitleChanged(callback)
+    return self:bidirectional_streaming_request(pinnacle.signal.v1.SignalService.WindowTitleChanged, callback)
+end
 pinnacle.signal.v1.SignalService.TagActive = {}
 pinnacle.signal.v1.SignalService.TagActive.service = "pinnacle.signal.v1.SignalService"
 pinnacle.signal.v1.SignalService.TagActive.method = "TagActive"

api/lua/pinnacle/input.lua

@@ -722,13 +722,11 @@ local signal_name_to_SignalName = {
 ---@see pinnacle.signal.SignalHandles.disconnect_all - To disconnect from these signals
 function input.connect_signal(signals)
     ---@diagnostic disable-next-line: invisible
-    local handles = require("pinnacle.signal").handles.new({})
+    local handles = require("pinnacle.signal").handles.new()
 
     for signal, callback in pairs(signals) do
-        require("pinnacle.signal").add_callback(signal_name_to_SignalName[signal], callback)
         local handle =
-            ---@diagnostic disable-next-line: invisible
-            require("pinnacle.signal").handle.new(signal_name_to_SignalName[signal], callback)
+            require("pinnacle.signal").add_callback(signal_name_to_SignalName[signal], callback)
         handles[signal] = handle
     end
 

api/lua/pinnacle/output.lua

@@ -180,13 +180,11 @@ local signal_name_to_SignalName = {
 ---@see pinnacle.signal.SignalHandles.disconnect_all - To disconnect from these signals
 function output.connect_signal(signals)
     ---@diagnostic disable-next-line: invisible
-    local handles = require("pinnacle.signal").handles.new({})
+    local handles = require("pinnacle.signal").handles.new()
 
     for signal, callback in pairs(signals) do
-        require("pinnacle.signal").add_callback(signal_name_to_SignalName[signal], callback)
         local handle =
-            ---@diagnostic disable-next-line: invisible
-            require("pinnacle.signal").handle.new(signal_name_to_SignalName[signal], callback)
+            require("pinnacle.signal").add_callback(signal_name_to_SignalName[signal], callback)
         handles[signal] = handle
     end