Use more idiomatic Effect helpers#2791
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Optionfor optional MagicDNS values,Durationconstants for timeouts, andSchema.TaggedErrorClassfor Tailscale errors.Optionshape and usedLayer.mockfor partial process service mocks.Schema.fromJsonStringdecoding and used aDurationtimeout constant.Why
These are small, focused Effect idiom improvements that make optional data, durations, serializable errors, service mocking, and JSON decoding more explicit and testable.
UI Changes
Not applicable.
Checklist
Note
Replace null checks with
Optionand numeric timeouts withDurationacross Tailscale and process utilitiesTailscaleStatus.magicDnsName,parseTailscaleMagicDnsName, andresolveTailscaleHttpsBaseUrlnow returnOption.Option<string>instead ofstring | null; callers useOption.some/Option.nonethroughout.tailscale.tsandProcessDiagnostics.tsare replaced withDuration-based values; observed durations are unchanged.TailscaleCommandError,TailscaleStatusParseError,TailscaleUnavailableError) are migrated fromData.TaggedErrortoSchema.TaggedErrorClass.ProcessDiagnostics.tsis refactored to useSchema-based parsing withdecodeUnknownOption, replacing a manualJSON.parsetry/catch.Layer.mockfor spawner mocks andOption-aware assertions.magicDnsName,parseTailscaleMagicDnsName, orresolveTailscaleHttpsBaseUrlmust now handleOptioninstead of nullable strings.Macroscope summarized bc3c829.