Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store inside LoadDataController is not closed #60352

Open
D3Hunter opened this issue Apr 1, 2025 · 0 comments
Open

store inside LoadDataController is not closed #60352

D3Hunter opened this issue Apr 1, 2025 · 0 comments
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Apr 1, 2025

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

if we init data store, we need close it later, but LoadDataController doesn't have a close method now

func (e *LoadDataController) InitDataStore(ctx context.Context) error {

close of s3 is empty, but GCS store have something to close

tidb/br/pkg/storage/gcs.go

Lines 368 to 374 in 7af21d4

func (s *GCSStorage) Close() {
for _, client := range s.clients {
if err := client.Close(); err != nil {
log.Warn("failed to close gcs client", zap.Error(err))
}
}
}

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant