Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle non-existing tokens in voucher token condition #135

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Gracefully handle non-existing tokens in voucher token condition #135

merged 2 commits into from
Nov 9, 2023

Conversation

jdreesen
Copy link
Contributor

@jdreesen jdreesen commented Nov 6, 2023

When the token does not exist, VoucherServiceToken::getByCode() will return null, which results in a Call to a member function getVoucherSeriesId() on null exception instead of returning a boolean in checkVoucherCode().

@dvesh3
Copy link
Contributor

dvesh3 commented Nov 6, 2023

@jdreesen 1.0 branch?

@dvesh3 dvesh3 added the Bug label Nov 6, 2023
@jdreesen
Copy link
Contributor Author

jdreesen commented Nov 6, 2023

Right, it's already broken in Pimcore 10.

@jdreesen jdreesen changed the base branch from 1.x to 1.0 November 6, 2023 12:08
@dvesh3 dvesh3 added this to the 1.0.6 milestone Nov 7, 2023
@kingjia90 kingjia90 self-assigned this Nov 9, 2023
@kingjia90 kingjia90 merged commit 368cddc into pimcore:1.0 Nov 9, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@jdreesen jdreesen deleted the patch-1 branch November 9, 2023 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jdreesen @dvesh3 @kingjia90