Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more things to service work for performance reasons #2298

Open
thibaultmol opened this issue Dec 2, 2024 · 2 comments
Open

Move more things to service work for performance reasons #2298

thibaultmol opened this issue Dec 2, 2024 · 2 comments

Comments

@thibaultmol
Copy link
Collaborator

I don't know how the current code works, but I have a feeling (with the amount of times the main thread just straight up hangs) that a lot of work is still being done on the main thread, that could be done on the service worker. So that the main thread can focus on the actual ux being smooth.

The fact I get ui hangs.... on a Ryzen 7 7840U on performance mode.... is not normal. (i'm on the parking theme. not the bus or personal theme)

@pietervdvn
Copy link
Owner

I know, but using the service worker is somewhat complicated...

@thibaultmol
Copy link
Collaborator Author

I know, I understand. But I figured it'd make this issue just as a todo item for doing it eventually. It's going to be a big performance improvement I think.

Also maybe there are things in libraries you're already using that make using services workers for this stuff easier, i don't know

pietervdvn pushed a commit that referenced this issue Jan 17, 2025
…van-der-Linde/MapComplete:patch-1 into develop

Reviewed-on: https://source.mapcomplete.org/MapComplete/MapComplete/pulls/2298
Reviewed-by: Pieter Vander Vennet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants