Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCloud Passwords popup rendering outside the viewport #3195

Closed
felixsts opened this issue Jan 16, 2025 · 1 comment
Closed

iCloud Passwords popup rendering outside the viewport #3195

felixsts opened this issue Jan 16, 2025 · 1 comment

Comments

@felixsts
Copy link

Versions

  • Pi-hole: v5.18.3
  • AdminLTE: v5.21
  • FTL: v5.25.2

Platform

  • OS and version: Ubuntu Server 24.04.1 LTS (server), macOS 15.2 (client)
  • Platform: Docker 27.5.0

Expected behavior

The Passwords app should suggest a saved password when the user clicks the password field.

Like this:
Image

Actual behavior / bug

Chrome: The iCloud Passwords extension injects an iframe to render the password suggestion, but it renders outside the viewport (maybe a CSS conflict?).

Image

Safari: I couldn't find an iframe injected into the page, so it may behave differently.

Steps to reproduce

  1. Open the dashboard in Safari or any other browser with the iCloud Passwords extension (chrome-based or Firefox)
  2. Sign in with your password and accept when prompted to save the password to your keychain.
  3. Sign out
  4. On the login page, click the password field
  5. Nothing happens

Debug Token

Additional context

Browsers tested: Safari (18.2 - 20620.1.16.11.8), Chrome (131.0.6778.265 with iCloud Passwords extension), and Firefox (134.0 with iCloud Passwords extension)

@felixsts
Copy link
Author

felixsts commented Jan 16, 2025

I found the problem. The iframe is being rendered outside the viewport because the extension can't find the right password. The extension hides the iframe so that it doesn't appear empty on the screen.

Also, I manually added my password in the Passwords app with a random username, thinking that the username wasn't important (it is) since the page only asks for the password. Changing the username to "pi.hole" (which is the default value in the hidden username field) fixes the problem and the password suggestion works as expected.

It's also worth mentioning that Safari doesn't prompt you to save the password when you login to the dashboard because of the "value" property in the input field. If you remove it and enter the username manually, you will be prompted to save the password. Chrome will prompt you, but will not save the password regardless of the input properties (this may be an extension issue). Firefox doesn't prompt you to save the password at all, regardless of the input properties (this may also be an extension issue, as the extension has recently been ported to Firefox).

Anyway, I'll close the issue as it's not related to the pi-hole project at all. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant