From 4c026f3fb291797c109adcabda6aeba6491fe44f Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Tue, 31 May 2022 12:27:37 +0200 Subject: [PATCH 1/2] use isolate version of v8::ScriptOrigin --- v8js_class.cc | 2 +- v8js_methods.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/v8js_class.cc b/v8js_class.cc index 4e9be672..b8af58b1 100644 --- a/v8js_class.cc +++ b/v8js_class.cc @@ -636,7 +636,7 @@ static void v8js_compile_script(zval *this_ptr, const zend_string *str, const ze v8::Local sname = identifier ? V8JS_ZSTR(identifier) : V8JS_SYM("V8Js::compileString()"); - v8::ScriptOrigin origin(sname); + v8::ScriptOrigin origin(isolate, sname); if (ZSTR_LEN(str) > std::numeric_limits::max()) { zend_throw_exception(php_ce_v8js_exception, diff --git a/v8js_methods.cc b/v8js_methods.cc index 7f7f9261..7ddfcf82 100644 --- a/v8js_methods.cc +++ b/v8js_methods.cc @@ -516,7 +516,7 @@ V8JS_METHOD(require) // Set script identifier v8::Local sname = V8JS_STR(normalised_module_id); - v8::ScriptOrigin origin(sname); + v8::ScriptOrigin origin(isolate, sname); if (Z_STRLEN(module_code) > std::numeric_limits::max()) { zend_throw_exception(php_ce_v8js_exception, From 7247e9fee0f072ba9a8401fd4183316ea645723d Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Tue, 31 May 2022 12:28:24 +0200 Subject: [PATCH 2/2] change minimum v8 version to 9.0 --- README.md | 2 +- config.m4 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 64182da5..f0da5ca3 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ Minimum requirements V8 is written in C++ and is used in Google Chrome, the open source browser from Google. V8 implements ECMAScript as specified in ECMA-262, 5th edition. - This extension requires V8 7.5 or higher. + This extension requires V8 9.0 or higher. V8 releases are published rather quickly and the V8 team usually provides security support for the version line shipped with the Chrome browser (stable channel) and newer (only). diff --git a/config.m4 b/config.m4 index 44918def..bb823f42 100644 --- a/config.m4 +++ b/config.m4 @@ -140,8 +140,8 @@ int main () set $ac_cv_v8_version IFS=$ac_IFS V8_API_VERSION=`expr [$]1 \* 1000000 + [$]2 \* 1000 + [$]3` - if test "$V8_API_VERSION" -lt 7005000 ; then - AC_MSG_ERROR([libv8 must be version 7.5 or greater]) + if test "$V8_API_VERSION" -lt 9000000 ; then + AC_MSG_ERROR([libv8 must be version 9.0 or greater]) fi AC_DEFINE_UNQUOTED([PHP_V8_API_VERSION], $V8_API_VERSION, [ ]) AC_DEFINE_UNQUOTED([PHP_V8_VERSION], "$ac_cv_v8_version", [ ])