Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken build on PHP 8.0.x #502

Closed
marekskopal opened this issue Feb 8, 2023 · 2 comments
Closed

Broken build on PHP 8.0.x #502

marekskopal opened this issue Feb 8, 2023 · 2 comments

Comments

@marekskopal
Copy link
Contributor

marekskopal commented Feb 8, 2023 •
edited
Loading

Hi,

After changes from this pull request #498 build on PHP 8.0.x is broken.

If I revert those changes, build works fine.

On 8.1.x its fine too.

I suppose that zend_is_graceful_exit is not present in 8.0
@marekskopal
Copy link
Contributor Author

I created a pull request that should fix it #503

@stesie
Copy link
Member

stesie commented Feb 8, 2023

PR's merged. Thanks for pointing this out 👍

@stesie stesie closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stesie @marekskopal