Skip to content

Commit

Permalink
adapt code to handle php 8.4 too (based on @JoshuaBehrens & @rbro work)
Browse files Browse the repository at this point in the history
cf 2025daf

Signed-off-by: Romain Gautier <[email protected]>
  • Loading branch information
mykiwi committed Jan 3, 2025
1 parent 5234490 commit 48f0296
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions v8js_object_export.cc
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,11 @@ v8::Local<v8::Value> v8js_named_property_callback(v8::Isolate *isolate, v8::Loca
ce = scope = object->ce;

/* First, check the (case-insensitive) method table */
#if PHP_VERSION_ID < 80400
php_strtolower(lower, name_len);
#else
zend_str_tolower(lower, name_len);
#endif
method_name = zend_string_init(lower, name_len, 0);

// toString() -> __tostring()
Expand Down

0 comments on commit 48f0296

Please sign in to comment.