Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 9fd0cd8

Browse files
pinepainpinepain
committed
Fix false-positive v8 6.3 valgrind reports, closes #47 
1 parent 8fc173f commit 9fd0cd8

File tree

140 files changed

+334
-128
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+334
-128
lines changed

‎.valgrind-v8.supp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
<suppress_false_positive_warning_see_v8_issue_6566>
3+
Memcheck:Cond
4+
fun:_ZN2v88internal20MarkCompactCollector20EmptyMarkingWorklistEv
5+
...
6+
}

‎.valgrindrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--gen-suppressions=all
2+
--suppressions=./.valgrind-v8.supp

‎tests/001-extension_info.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
v8 extension info
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

‎tests/001-verify-method-case.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check whether all methods follows naming convention
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
$re = new ReflectionExtension('v8');

‎tests/001-verify-methods-signature.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check whether methods signature is valid
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
$re = new ReflectionExtension('v8');

‎tests/001-verify_extension_entities.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
Check whether all method parameters have valid type
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

‎tests/001.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Check for v8 presence
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79
echo "v8 extension is available";

‎tests/002-enums.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
--TEST--
22
Built-in enum classes
33
--SKIPIF--
4-
<?php if (!extension_loaded("v8")) {
5-
print "skip";
6-
} ?>
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
77
--FILE--
88
<?php
99

‎tests/003-V8ObjectTemplate_recursive_chain.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate - recursive 2
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

‎tests/003-V8ObjectTemplate_recursive_global.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
V8\ObjectTemplate
33
--SKIPIF--
44
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
57
--FILE--
68
<?php
79

0 commit comments

Comments
 (0)