fix

Author: staabm

src/Rules/Properties/PropertyInClassRule.php

@@ -81,6 +81,7 @@ public function processNode(Node $node, Scope $scope): array
 			];
 		}
 
+		if (
 			$node->isFinal()
 			&& !$node->hasHooks()
 			&& (!$this->phpVersion->supportsNonPrivateFinalProperties() || $node->isPrivate())
@@ -94,28 +95,26 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if ($node->isPrivate()) {
-			if ($node->hasHooks()) {
-				if ($node->isFinal()) {
-					return [
-						RuleErrorBuilder::message('Hooked properties cannot be both final and private.')
-							->nonIgnorable()
-							->identifier('property.abstractPrivate')
-							->build(),
-					];
-				}
+			if ($node->isFinal()) {
+				return [
+					RuleErrorBuilder::message('Properties cannot be both final and private.')
+						->nonIgnorable()
+						->identifier('property.finalPrivate')
+						->build(),
+				];
+			}
 
-				foreach ($node->getHooks() as $hook) {
-					if (!$hook->isFinal()) {
-						continue;
-					}
-
-					return [
-						RuleErrorBuilder::message('Hooked properties cannot be both final and private.')
-							->nonIgnorable()
-							->identifier('property.abstractPrivate')
-							->build(),
-					];
+			foreach ($node->getHooks() as $hook) {
+				if (!$hook->isFinal()) {
+					continue;
 				}
+
+				return [
+					RuleErrorBuilder::message('Properties cannot be both final and private.')
+						->nonIgnorable()
+						->identifier('property.finalPrivate')
+						->build(),
+				];
 			}
 		}
 

tests/PHPStan/Rules/Properties/data/private-final-property-hooks.php

@@ -8,8 +8,9 @@ final class User
 		get => 'private:' . $this->privatePropGet;
 	}
 
-	private string $privateSet = 'mailto: example.org' {
-		final set => 'private:' . $this->privateSet;
+	private string $private = 'mailto: example.org' {
+		final set => 'private:' . $this->private;
+		get => 'private:' . $this->private;
 	}
 
 	protected string $protected = 'mailto: example.org' {