Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getters & setters are added outside namespace #7

Open
phproberto opened this issue Feb 28, 2018 · 0 comments
Open

Getters & setters are added outside namespace #7

phproberto opened this issue Feb 28, 2018 · 0 comments
Labels

Comments

@phproberto
Copy link
Owner

Test functionality with some odd people that defines classes inside namespaces instead of just defining active namespace in the top of the file. I think we can definitely improve parent class detection.

Also needs #6

Michael Waack
Works fine.

Multiple create getters works only, if the first word starts with '$'
So if u select Lines, the first word start with "protected" and i get Error:
"No property found. Please select a property to use this extension."

Any way to change the format?
We using brackets in same line.

One Bug:
Using Namesapces, the getters and Setters where build in the Namespace, not in the Class:

namesapce FOO {
   class BAR {
     protected $lump; // create Getter
  }
// ERROR: Its outside the class:
  public function getLump()
  {
     return $this->lump;
  }
}
@phproberto phproberto added the bug label Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant