Skip to content

Commit abe889a

Browse files
committed
small correction in regex
1 parent 0a99d5b commit abe889a

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/Specification/InPath.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function isSatisfiedBy(array $value)
4949
$validChars = '[a-zA-Z0-9\\\/\.\<\>\,\|\:\(\)\&\;\#]';
5050

5151
$pattern = '(^(?!\/)'
52-
. str_replace(['?', '*'], [$validChars . '?', $validChars . '*'], $path)
52+
. str_replace(['?', '*'], [$validChars . '{1}', $validChars . '*'], $path)
5353
. $validChars . '*)';
5454

5555
if (preg_match($pattern, $value['dirname'] . '/')) {

tests/unit/Specification/InPathTest.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,16 @@ public function validDirnames()
5555
['.hiddendir/n'],
5656
['.hiddendir/n/'],
5757
['.hiddendir/n/somedir'],
58-
['.hiddendir/n/somedir.txt']
58+
['.hiddendir/n/somedir.txt'],
59+
['ddenxir/n']
5960
];
6061
}
6162

6263
/**
6364
* @covers ::__construct
6465
* @covers ::isSatisfiedBy
6566
* @covers ::<private>
66-
* @dataProvider InvalidDirnames
67+
* @dataProvider invalidDirnames
6768
* @uses Flyfinder\Path
6869
*/
6970
public function testIfSpecificationIsNotSatisfied($dirname)
@@ -76,12 +77,14 @@ public function testIfSpecificationIsNotSatisfied($dirname)
7677
*
7778
* @return array
7879
*/
79-
public function InvalidDirnames()
80+
public function invalidDirnames()
8081
{
8182
return [
8283
['/hiddendir/n'],
8384
['.hiddendir/normaldir'],
84-
['.hiddendir.ext/n']
85+
['.hiddendir.ext/n'],
86+
['.hiddenxxir/n'],
87+
['.hiddenir/n']
8588
];
8689
}
8790
}

0 commit comments

Comments
 (0)