Skip to content

Add test for iptcparse #18675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

magikid
Copy link

@magikid magikid commented May 27, 2025

This function parses IPTC image tags from images. It had no test coverage though. I discovered a reference image on the IPTC website so downloaded it and this test parses and validates that the iptcparse function correctly matches the tags in the image.

This function parses IPTC image tags from images.  It had no test coverage
though. I discovered a reference image on the IPTC website so downloaded it and
this test parses and validates that the `iptcparse` function correctly matches
the tags in the image.
@SakiTakamachi
Copy link
Member

SakiTakamachi commented May 28, 2025

From what I can see, there appears to be an issue with the licensing of the image regarding its usage.
https://iptc.org/tests/licensing-of-images-test-page/

Edit:
However, I'm not confident about how the licensing applies in cases where the image is not used in its original form, but rather in a modified or derivative way like this.

@magikid
Copy link
Author

magikid commented May 28, 2025

Good find. I'll see if I can either create an image myself with those tags or find one with a compatible license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants