Skip to content

Commit f73d51a

Browse files
committed
fix: sizeof-1 -> strlen
1 parent 89bff66 commit f73d51a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ext/random/engine_mt19937.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ PHP_METHOD(Random_Engine_Mt19937, __debugInfo)
394394
zend_throw_exception(NULL, "Engine serialize failed", 0);
395395
RETURN_THROWS();
396396
}
397-
zend_hash_str_add(Z_ARR_P(return_value), "__states", sizeof("__states") - 1, &t);
397+
zend_hash_str_add(Z_ARR_P(return_value), "__states", strlen("__states"), &t);
398398
}
399399
}
400400
/* }}} */

ext/random/randomizer.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ static inline void randomizer_common_init(php_random_randomizer *randomizer, zen
4242
zend_string *mname;
4343
zend_function *generate_method;
4444

45-
mname = zend_string_init("generate", sizeof("generate") - 1, 0);
45+
mname = zend_string_init("generate", strlen("generate"), 0);
4646
generate_method = zend_hash_find_ptr(&engine_object->ce->function_table, mname);
4747
zend_string_release(mname);
4848

@@ -274,7 +274,7 @@ PHP_METHOD(Random_Randomizer, __unserialize)
274274
}
275275
object_properties_load(&randomizer->std, Z_ARRVAL_P(members_zv));
276276

277-
zengine = zend_read_property(randomizer->std.ce, &randomizer->std, "engine", sizeof("engine") - 1, 0, NULL);
277+
zengine = zend_read_property(randomizer->std.ce, &randomizer->std, "engine", strlen("engine"), 0, NULL);
278278
if (Z_TYPE_P(zengine) != IS_OBJECT || !instanceof_function(Z_OBJCE_P(zengine), random_ce_Random_Engine)) {
279279
zend_throw_exception(NULL, "Incomplete or ill-formed serialization data", 0);
280280
RETURN_THROWS();

0 commit comments

Comments
 (0)