Fix ASAN undefined behavior (unsigned char << 24)

ext/mbstring/libmbfl/filters/mbfilter_utf32.c:259:20: runtime error: left shift of 128 by 24 places cannot be represented in type 'int'

Author: dstogov

ext/mbstring/libmbfl/filters/mbfilter_ucs4.c

@@ -320,10 +320,10 @@ static size_t mb_ucs4_to_wchar(unsigned char **in, size_t *in_len, uint32_t *buf
 		return mb_ucs4le_to_wchar(in, in_len, buf, bufsize, NULL);
 	} else if (*in_len >= 4) {
 		unsigned char *p = *in;
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c1 << 24) | (c2 << 16) | (c3 << 8) | c4;
 
 		if (w == 0xFFFE0000) {
@@ -349,10 +349,10 @@ static size_t mb_ucs4be_to_wchar(unsigned char **in, size_t *in_len, uint32_t *b
 	uint32_t *out = buf, *limit = buf + bufsize;
 
 	while (p < e && out < limit) {
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c1 << 24) | (c2 << 16) | (c3 << 8) | c4;
 		*out++ = w;
 	}
@@ -393,10 +393,10 @@ static size_t mb_ucs4le_to_wchar(unsigned char **in, size_t *in_len, uint32_t *b
 	uint32_t *out = buf, *limit = buf + bufsize;
 
 	while (p < e && out < limit) {
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c4 << 24) | (c3 << 16) | (c2 << 8) | c1;
 		*out++ = w;
 	}

ext/mbstring/libmbfl/filters/mbfilter_utf32.c

@@ -252,10 +252,10 @@ static size_t mb_utf32_to_wchar(unsigned char **in, size_t *in_len, uint32_t *bu
 		return mb_utf32le_to_wchar(in, in_len, buf, bufsize, NULL);
 	} else if (*in_len >= 4) {
 		unsigned char *p = *in;
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c1 << 24) | (c2 << 16) | (c3 << 8) | c4;
 
 		if (w == 0xFFFE0000) {
@@ -281,10 +281,10 @@ static size_t mb_utf32be_to_wchar(unsigned char **in, size_t *in_len, uint32_t *
 	uint32_t *out = buf, *limit = buf + bufsize;
 
 	while (p < e && out < limit) {
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c1 << 24) | (c2 << 16) | (c3 << 8) | c4;
 
 		if (w < MBFL_WCSPLANE_UTF32MAX && (w < 0xD800 || w > 0xDFFF)) {
@@ -330,10 +330,10 @@ static size_t mb_utf32le_to_wchar(unsigned char **in, size_t *in_len, uint32_t *
 	uint32_t *out = buf, *limit = buf + bufsize;
 
 	while (p < e && out < limit) {
-		unsigned char c1 = *p++;
-		unsigned char c2 = *p++;
-		unsigned char c3 = *p++;
-		unsigned char c4 = *p++;
+		uint32_t c1 = *p++;
+		uint32_t c2 = *p++;
+		uint32_t c3 = *p++;
+		uint32_t c4 = *p++;
 		uint32_t w = (c4 << 24) | (c3 << 16) | (c2 << 8) | c1;
 
 		if (w < MBFL_WCSPLANE_UTF32MAX && (w < 0xD800 || w > 0xDFFF)) {