fixup! Implement the "Redacting parameters in back traces" RFC

Author: TimWolla

Zend/tests/function_arguments/sensitive_parameter_value.phpt

@@ -5,18 +5,41 @@ The SensitiveParameterValue behaves as expected.
 
 $v = new SensitiveParameterValue('secret');
 
+echo "# var_dump() / debug_zval_dump()", PHP_EOL;
 var_dump($v);
+debug_zval_dump($v);
+echo PHP_EOL;
+
+echo "# var_export()", PHP_EOL;
+echo var_export($v, true), PHP_EOL;
+echo PHP_EOL;
+
+echo "# (array) / serialize() / json_encode()", PHP_EOL;
 var_dump((array)$v);
 var_dump(serialize($v));
 var_dump(json_encode($v));
+echo PHP_EOL;
+
+echo "# ->getValue()", PHP_EOL;
 var_dump($v->getValue());
 
 ?>
 --EXPECTF--
+# var_dump() / debug_zval_dump()
 object(SensitiveParameterValue)#%d (0) {
 }
+object(SensitiveParameterValue)#%d (%d) refcount(%d){
+}
+
+# var_export()
+SensitiveParameterValue::__set_state(array(
+))
+
+# (array) / serialize() / json_encode()
 array(0) {
 }
 string(35) "O:23:"SensitiveParameterValue":0:{}"
 string(2) "{}"
+
+# ->getValue()
 string(6) "secret"

Zend/zend_attributes.c

@@ -178,11 +178,7 @@ static void attributes_sensitive_parameter_value_free_obj(zend_object *object)
 
 static HashTable *attributes_sensitive_parameter_value_get_properties_for(zend_object *zobj, zend_prop_purpose purpose)
 {
-	if (purpose == ZEND_PROP_PURPOSE_ARRAY_CAST) {
-		return NULL;
-	} else {
-		return zend_std_get_properties_for(zobj, purpose);
-	}
+	return NULL;
 }
 
 static zend_attribute *get_attribute(HashTable *attributes, zend_string *lcname, uint32_t offset)