Skip to content

feat(extgen): add integration tests #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(extgen): add integration tests #1984

wants to merge 2 commits into from

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Nov 17, 2025

Fix #1975

@alexandre-daubois alexandre-daubois force-pushed the integration-extinit branch 21 times, most recently from dd92852 to b784ea3 Compare November 21, 2025 08:43
@alexandre-daubois alexandre-daubois marked this pull request as ready for review November 21, 2025 08:46
@alexandre-daubois alexandre-daubois requested a review from a team November 21, 2025 08:47
AlliBalliBaba
AlliBalliBaba reviewed Nov 21, 2025
View reviewed changes
@alexandre-daubois alexandre-daubois force-pushed the integration-extinit branch 3 times, most recently from 2dd102f to 9b05199 Compare November 24, 2025 10:31
@alexandre-daubois alexandre-daubois mentioned this pull request Nov 24, 2025
Open
@alexandre-daubois alexandre-daubois force-pushed the integration-extinit branch 2 times, most recently from abbb421 to b1cd29b Compare November 24, 2025 10:40
@alexandre-daubois alexandre-daubois force-pushed the integration-extinit branch 2 times, most recently from 6b81e83 to 91247d9 Compare December 1, 2025 10:34
@alexandre-daubois alexandre-daubois mentioned this pull request Dec 1, 2025
Merged
@alexandre-daubois alexandre-daubois mentioned this pull request Dec 1, 2025
Merged
alexandre-daubois added a commit that referenced this pull request Dec 1, 2025
@alexandre-daubois
fix(extgen): use REGISTER(_NS)_BOOL_CONSTANT (#2047)
2fa7663 
Spotted in #1984, this is the right macros to declare boolean constants
alexandre-daubois added a commit that referenced this pull request Dec 1, 2025
@alexandre-daubois
fix(extgen): use RETURN_EMPTY_STRING() when returning empty string (#…
1fbabf9 
…2049)

One last bug spotted by #1984, empty strings should be returned using
`RETURN_EMPTY_STRING()` or it may segfault.
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Dec 1, 2025

Integration tests for extgen are green, ready for review @php/frankenphp-collaborators!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlliBalliBaba AlliBalliBaba AlliBalliBaba left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add functional tests for extgen

2 participants

@alexandre-daubois @AlliBalliBaba