fix: thread restart

Author: arturmelanchyk

phpthread.go

@@ -79,6 +79,18 @@ func (thread *phpThread) shutdown() {
 	}
 }
 
+// restart the underlying PHP thread
+func (thread *phpThread) restart() {
+	if !thread.state.requestSafeStateChange(stateRestarting) {
+		return
+	}
+	close(thread.drainChan)
+	thread.state.waitFor(stateYielding)
+	thread.drainChan = make(chan struct{})
+
+	thread.state.waitFor(stateYielding)
+}
+
 // change the thread handler safely
 // must be called from outside the PHP thread
 func (thread *phpThread) setHandler(handler threadHandler) {

worker.go

@@ -148,16 +148,8 @@ func drainWorkerThreads() []*phpThread {
 		worker.threadMutex.RLock()
 		ready.Add(len(worker.threads))
 		for _, thread := range worker.threads {
-			if !thread.state.requestSafeStateChange(stateRestarting) {
-				ready.Done()
-				// no state change allowed == thread is shutting down
-				// we'll proceed to restart all other threads anyways
-				continue
-			}
-			close(thread.drainChan)
-			drainedThreads = append(drainedThreads, thread)
 			go func(thread *phpThread) {
-				thread.state.waitFor(stateYielding)
+				thread.restart()
 				ready.Done()
 			}(thread)
 		}