Improve documentation and code

Improve RequestException

Remove unnecessary TransferException stub

Improve Exception

Remove unused import

Improve Change Log

Improve composer.json

Add the team to the license file

Replace gitter with slack

Fix badge URL

Author: sagikazarmark

CHANGELOG.md

@@ -1,6 +1,23 @@
 # Change Log
 
 
+## 1.0.0 - Unreleased
+
+### Added
+
+- Better domain exceptions.
+
+### Changed
+
+- Purpose of the library: general HTTP CLient abstraction.
+
+### Removed
+
+- Request options: they should be configured at construction time.
+- Multiple request sending: should be done asynchronously using Async Client.
+- `getName` method
+
+
 ## 0.1.0 - 2015-06-03
 
 ### Added

LICENSE

@@ -1,4 +1,5 @@
 Copyright (c) 2014-2015 Eric GELOEN <[email protected]>
+Copyright (c) 2015 PHP HTTP Team <[email protected]>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -7,7 +7,7 @@
 [![Quality Score](https://img.shields.io/scrutinizer/g/php-http/httplug.svg?style=flat-square)](https://scrutinizer-ci.com/g/php-http/httplug)
 [![Total Downloads](https://img.shields.io/packagist/dt/php-http/httplug.svg?style=flat-square)](https://packagist.org/packages/php-http/httplug)
 
-[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/php-http/httplug?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![Slack Status](http://slack.httplug.io/badge.svg)](http://slack.httplug.io)
 
 **HTTPlug, the HTTP client abstraction for PHP.**
 

composer.json

@@ -3,7 +3,7 @@
     "description": "HTTPlug, the HTTP client abstraction for PHP",
     "license": "MIT",
     "keywords": ["http", "client"],
-    "homepage": "http://php-http.org",
+    "homepage": "http://httplug.io",
     "authors": [
         {
             "name": "Eric GELOEN",

spec/Exception/HttpExceptionSpec.php

@@ -10,8 +10,6 @@ class HttpExceptionSpec extends ObjectBehavior
 {
     function let(RequestInterface $request, ResponseInterface $response)
     {
-        $response->getStatusCode()->willReturn(400);
-
         $this->beConstructedWith('message', $request, $response);
     }
 

spec/Exception/TransferExceptionSpec.php

@@ -2,16 +2,10 @@
 
 namespace spec\Http\Client\Exception;
 
-use Http\Client\Exception\TransferException;
 use PhpSpec\ObjectBehavior;
 
 class TransferExceptionSpec extends ObjectBehavior
 {
-    function let()
-    {
-        $this->beAnInstanceOf('spec\Http\Client\Exception\TransferExceptionStub');
-    }
-
     function it_is_a_runtime_exception()
     {
         $this->shouldHaveType('RuntimeException');
@@ -22,7 +16,3 @@ function it_is_an_exception()
         $this->shouldImplement('Http\Client\Exception');
     }
 }
-
-class TransferExceptionStub extends TransferException
-{
-}

src/Exception.php

@@ -3,7 +3,7 @@
 namespace Http\Client;
 
 /**
- * Every HTTP Client related Exception must implement this interface
+ * Every HTTP Client related Exception must implement this interface.
  *
  * @author Márk Sági-Kazár <[email protected]>
  */

src/Exception/HttpException.php

@@ -6,7 +6,7 @@
 use Psr\Http\Message\ResponseInterface;
 
 /**
- * Thrown when a response was received but has an error status code.
+ * Thrown when a response was received but the request itself failed.
  *
  * In addition to the request, this exception always provides access to the response object.
  *
@@ -38,7 +38,7 @@ public function __construct(
     }
 
     /**
-     * Returns the response
+     * Returns the response.
      *
      * @return ResponseInterface
      */
@@ -48,7 +48,7 @@ public function getResponse()
     }
 
     /**
-     * Factory method to create a new exception with a normalized error message
+     * Factory method to create a new exception with a normalized error message.
      *
      * @param RequestInterface  $request
      * @param ResponseInterface $response

src/Exception/RequestException.php

@@ -32,7 +32,7 @@ public function __construct($message, RequestInterface $request, \Exception $pre
     }
 
     /**
-     * Returns the request
+     * Returns the request.
      *
      * @return RequestInterface
      */

src/HttpClient.php

@@ -2,7 +2,6 @@
 
 namespace Http\Client;
 
-use Http\Client\Exception\BatchException;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;