Throw exceptions instead of using assertions

Author: mekras

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Fixed
+
+- #36: Failure evaluating code: is_resource($handle) (string assertions are deprecated in PHP 7.2)
 
 ## 1.7 - 2017-02-09
 

src/PromiseCore.php

@@ -67,17 +67,34 @@ class PromiseCore
     /**
      * Create shared core.
      *
-     * @param RequestInterface $request         HTTP request
-     * @param resource         $handle          cURL handle
-     * @param ResponseBuilder  $responseBuilder
+     * @param RequestInterface $request HTTP request.
+     * @param resource         $handle cURL handle.
+     * @param ResponseBuilder  $responseBuilder Response builder.
+     *
+     * @throws \InvalidArgumentException If $handle is not a cURL resource.
      */
     public function __construct(
         RequestInterface $request,
         $handle,
         ResponseBuilder $responseBuilder
     ) {
-        assert(is_resource($handle));
-        assert(get_resource_type($handle) === "curl");
+        if (!is_resource($handle)) {
+            throw new \InvalidArgumentException(
+                sprintf(
+                    'Parameter $handle expected to be a cURL resource, %s given',
+                    gettype($handle)
+                )
+            );
+        }
+
+        if (get_resource_type($handle) !== 'curl') {
+            throw new \InvalidArgumentException(
+                sprintf(
+                    'Parameter $handle expected to be a cURL resource, %s resource given',
+                    get_resource_type($handle)
+                )
+            );
+        }
 
         $this->request = $request;
         $this->handle = $handle;

tests/PromiseCoreTest.php

@@ -16,6 +16,40 @@
  */
 class PromiseCoreTest extends BaseUnitTestCase
 {
+    /**
+     * Testing if handle is not a resource.
+     */
+    public function testHandleIsNotAResource()
+    {
+        $this->setExpectedException(
+            \InvalidArgumentException::class,
+            'Parameter $handle expected to be a cURL resource, NULL given'
+        );
+
+        new PromiseCore(
+            $this->createRequest('GET', '/'),
+            null,
+            new ResponseBuilder($this->createResponse())
+        );
+    }
+
+    /**
+     * Testing if handle is not a cURL resource.
+     */
+    public function testHandleIsNotACurlResource()
+    {
+        $this->setExpectedException(
+            \InvalidArgumentException::class,
+            'Parameter $handle expected to be a cURL resource, stream resource given'
+        );
+
+        new PromiseCore(
+            $this->createRequest('GET', '/'),
+            fopen('php://memory', 'r+b'),
+            new ResponseBuilder($this->createResponse())
+        );
+    }
+
     /**
      * Test on fulfill actions.
      */